From: Ping-Ke Shih <pkshih@realtek.com>
To: "martin.blumenstingl@googlemail.com"
<martin.blumenstingl@googlemail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: rtw89: station mode only for SDIO chips
Date: Wed, 27 Mar 2024 00:41:39 +0000 [thread overview]
Message-ID: <3d18a17216c0352d656dd4783d131c8f65d26370.camel@realtek.com> (raw)
In-Reply-To: <CAFBinCDdagAbmTBx_4qezbaPwrEK+5YaQhTZm_YjnrMc4OSJ6g@mail.gmail.com>
On Tue, 2024-03-26 at 20:34 +0100, Martin Blumenstingl wrote:
>
> Hello Ping-Ke,
>
> On Tue, Mar 26, 2024 at 2:48 AM Ping-Ke Shih <pkshih@realtek.com> wrote:
> > Since only station mode has been tested on SDIO chips, only keep it support
> > for SDIO chips to reflect correct supported features.
> Overall I'm fine with this patch, thanks for taking care of it!
>
> I only have one small comment: the subject line should start with
> "wifi: rtw88: ..." (currently it states rtw89)
Ah. Somehow I made this mistake. I'm adding a rule to avoid this in my scripts
locally. Thanks for pointing out this.
> With that changed:
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> Also I'm hoping that some people will step up and find the missing
> link to get AP mode working on SDIO chips. I currently don't have time
> for this.
>
I hope so. Thanks for the effort you have made. :)
Ping-Ke
prev parent reply other threads:[~2024-03-27 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 1:47 [PATCH] wifi: rtw89: station mode only for SDIO chips Ping-Ke Shih
2024-03-26 19:34 ` Martin Blumenstingl
2024-03-27 0:41 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d18a17216c0352d656dd4783d131c8f65d26370.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).