linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: ath10k and min_gcd + adhoc issues in 4.20 kernel
Date: Tue, 15 Jan 2019 15:29:38 -0800	[thread overview]
Message-ID: <3dfff3d9-a070-f3a3-723c-d1442ec06bc5@candelatech.com> (raw)

I just updated to 4.20 and ported forward my ath10k patches.  Now the driver
will not register with mac80211 because this warning hits in net/wireless/core.c:

			/*
			 * This isn't well-defined right now. If you have an
			 * IBSS interface, then its beacon interval may change
			 * by joining other networks, and nothing prevents it
			 * from doing that.
			 * So technically we probably shouldn't even allow AP
			 * and IBSS in the same interface, but it seems that
			 * some drivers support that, possibly only with fixed
			 * beacon intervals for IBSS.
			 */
			if (WARN_ON(types & BIT(NL80211_IFTYPE_ADHOC) &&
				    c->beacon_int_min_gcd)) {
				return -EINVAL;
			}


It looks like this was triggered by:

Commit 0c317a02ca982ca093e71bf07cb562265ba40032
Author: Purushottam Kushwaha <pkushwah@qti.qualcomm.com>
Date:   Wed Oct 12 18:26:51 2016 +0530

     cfg80211: support virtual interfaces with different beacon intervals

and

commit 8ebee73b574ad3dd1f14d461f65ceaffbd637650
Author: Anilkumar Kolli <akolli@codeaurora.org>
Date:   Wed Mar 28 12:19:40 2018 +0300

     ath10k: advertize beacon_int_min_gcd


To be honest, I don't see why that check for beacon_int_min_gcd is in the registration
logic.  Having it be '1' means that the driver/nic/firmware is flexible on pretty much
any combination of beacon interval, so why should that trigger the WARN_ON case?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


             reply	other threads:[~2019-01-15 23:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 23:29 Ben Greear [this message]
2019-04-04 20:45 ` ath10k and min_gcd + adhoc issues in 4.20 kernel Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3dfff3d9-a070-f3a3-723c-d1442ec06bc5@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).