linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Ping-Ke Shih <pkshih@realtek.com>, kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, tiwai@suse.de
Subject: Re: [PATCH 0/3] rtw89: fix crash when loading firmware file on certain platforms
Date: Thu, 11 Nov 2021 12:43:37 -0600	[thread overview]
Message-ID: <40821ab1-3e0a-4546-669f-0a6bdcaf9361@lwfinger.net> (raw)
In-Reply-To: <20211111021457.13776-1-pkshih@realtek.com>

On 11/10/21 20:14, Ping-Ke Shih wrote:
> First patch is to avoid writing "partition size" on read-only firmware
> buffer, so it has to fix the crash.
> The later two patches are used to make the semantics clear, but they don't
> change the logic at all.
> 
> I hope at least first patch can be taken into 5.16-rc, so people can avoid
> this crash.

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
> 
> Ping-Ke Shih (3):
>    rtw89: update partition size of firmware header on skb->data
>    rtw89: add const in the cast of le32_get_bits()
>    rtw89: use inline function instead macro to set H2C and CAM
> 
>   drivers/net/wireless/realtek/rtw89/cam.h  |  468 ++++--
>   drivers/net/wireless/realtek/rtw89/fw.c   |    2 +-
>   drivers/net/wireless/realtek/rtw89/fw.h   | 1768 ++++++++++++---------
>   drivers/net/wireless/realtek/rtw89/txrx.h |   46 +-
>   4 files changed, 1370 insertions(+), 914 deletions(-)
> 


      parent reply	other threads:[~2021-11-11 18:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11  2:14 [PATCH 0/3] rtw89: fix crash when loading firmware file on certain platforms Ping-Ke Shih
2021-11-11  2:14 ` [PATCH 1/3] rtw89: update partition size of firmware header on skb->data Ping-Ke Shih
2021-11-11  2:14 ` [PATCH 2/3] rtw89: add const in the cast of le32_get_bits() Ping-Ke Shih
2021-11-11  2:14 ` [PATCH 3/3] rtw89: use inline function instead macro to set H2C and CAM Ping-Ke Shih
2021-11-11 18:43 ` Larry Finger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40821ab1-3e0a-4546-669f-0a6bdcaf9361@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).