From: Aloka Dixit <alokad@codeaurora.org>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] nl80211: Commands for FILS discovery and unsolicited broadcast probe response
Date: Mon, 25 Jan 2021 13:52:33 -0800 [thread overview]
Message-ID: <430f10a576b8490f73827f800c87f58c@codeaurora.org> (raw)
In-Reply-To: <ca7281ce-70bb-d1e2-3ec2-f07d91145c04@broadcom.com>
On 2021-01-20 02:10, Arend van Spriel wrote:
> On 20-01-2021 01:52, Aloka Dixit wrote:
>> This change moves the FILS discovery and unsolicited probe response
>> configurations to new netlink commands instead of during beacon set
>> up.
>> It allows modification of transmission parameters such as time
>> interval
>> dynamically.
>
> Why not have both, ie. support initial setup through START_AP and
> allow modifications with new command or an existing one. Maybe we
> should consolidate to what has been discussed in thread about AP power
> save [1].
>
> Regards,
> Arend
>
> [1]
> https://patchwork.kernel.org/project/linux-wireless/patch/1598257589-19091-1-git-send-email-vnaralas@codeaurora.org/
Hi Arend,
FILS discovery and especially unsolicited probe response templates are
big. Sometimes send_and_recv() returns error due to memory
unavailability during wpa_driver_nl80211_set_ap() depending on how many
interfaces, which elements are added. Moving these to separate commands
resolves this issue along with more control over the time interval
during run-time.
Thanks.
next prev parent reply other threads:[~2021-01-25 21:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 0:52 [PATCH 0/2] Commands for FILS discovery and unsolicited probe response Aloka Dixit
2021-01-20 0:52 ` [PATCH 1/2] nl80211: Commands for FILS discovery and unsolicited broadcast " Aloka Dixit
2021-01-20 10:10 ` Arend van Spriel
2021-01-25 21:52 ` Aloka Dixit [this message]
2021-02-12 9:33 ` Johannes Berg
2021-02-16 22:41 ` Aloka Dixit
2021-01-20 0:52 ` [PATCH 2/2] mac80211: " Aloka Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430f10a576b8490f73827f800c87f58c@codeaurora.org \
--to=alokad@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).