From: Christian Lamparter <chunkeey@gmail.com>
To: Pan Bian <bianpan2016@163.com>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: p54: drop device reference count if fails to enable device
Date: Fri, 19 Apr 2019 19:56:47 +0200 [thread overview]
Message-ID: <4374745.djV02MS7NJ@debian64> (raw)
In-Reply-To: <1555494083-130833-1-git-send-email-bianpan2016@163.com>
Subject should include a "[PATCH]" as per:
https://www.kernel.org/doc/html/v4.15/process/submitting-patches.html#include-patch-in-the-subject
Nevertheless, patchwork picked it up.... so, you are probably fine.
https://patchwork.kernel.org/patch/10905039/
On Wednesday, April 17, 2019 11:41:23 AM CEST Pan Bian wrote:
> The function p54p_probe takes an extra reference count of the PCI
> device. However, the extra reference count is not dropped when it fails
> to enable the PCI device. This patch fixes the bug.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Cc: stable@vger.kernel.org
Acked-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> drivers/net/wireless/intersil/p54/p54pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intersil/p54/p54pci.c b/drivers/net/wireless/intersil/p54/p54pci.c
> index 27a4906..57ad564 100644
> --- a/drivers/net/wireless/intersil/p54/p54pci.c
> +++ b/drivers/net/wireless/intersil/p54/p54pci.c
> @@ -554,7 +554,7 @@ static int p54p_probe(struct pci_dev *pdev,
> err = pci_enable_device(pdev);
> if (err) {
> dev_err(&pdev->dev, "Cannot enable new PCI device\n");
> - return err;
> + goto err_put;
> }
>
> mem_addr = pci_resource_start(pdev, 0);
> @@ -639,6 +639,7 @@ static int p54p_probe(struct pci_dev *pdev,
> pci_release_regions(pdev);
> err_disable_dev:
> pci_disable_device(pdev);
> +err_put:
> pci_dev_put(pdev);
> return err;
> }
>
next prev parent reply other threads:[~2019-04-19 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 9:41 p54: drop device reference count if fails to enable device Pan Bian
2019-04-19 17:56 ` Christian Lamparter [this message]
2019-04-25 16:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4374745.djV02MS7NJ@debian64 \
--to=chunkeey@gmail.com \
--cc=bianpan2016@163.com \
--cc=chunkeey@googlemail.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).