From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-yx0-f175.google.com ([209.85.210.175]:40046 "EHLO mail-yx0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961AbZGaSsg convert rfc822-to-8bit (ORCPT ); Fri, 31 Jul 2009 14:48:36 -0400 Received: by yxe5 with SMTP id 5so293387yxe.33 for ; Fri, 31 Jul 2009 11:48:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <40f31dec0907311125o1654bd23jee861ba8bea57611@mail.gmail.com> References: <20090731181020.GE7963@makis> <43e72e890907311115h56df6ac0p1ea7165e305a10ee@mail.gmail.com> <40f31dec0907311125o1654bd23jee861ba8bea57611@mail.gmail.com> From: "Luis R. Rodriguez" Date: Fri, 31 Jul 2009 11:48:16 -0700 Message-ID: <43e72e890907311148i3e5a302cg2efb713df706c103@mail.gmail.com> Subject: Re: [ath5k-devel] [PATCH 4/4] ath5k: Use SWI to trigger calibration To: Nick Kossifidis Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org, linville@tuxdriver.com, jirislaby@gmail.com, me@bobcopeland.com, nbd@openwrt.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Jul 31, 2009 at 11:25 AM, Nick Kossifidis wrote: > 2009/7/31 Luis R. Rodriguez : >> On Fri, Jul 31, 2009 at 11:10 AM, Nick >> Kossifidis wrote: >>>  * Get rid of calibration timer, instead use a software interrupt >>>   to schedule the calibration tasklet. >> >> An example of itemizing one change. Explain the why, not the how. >> > > We 've discussed this with various people on wireless summit. Not everyone attended. > a) We don't need a timer for this, there is no need for accuracy >    even with round_jiffies i think this is a waste of resources. >    Also we don't need to run calibration if we are idle (no interrupts). > > b) When we add ANI support we 'll just extend the poll function >    and calibration tasklet and handle all periodic phy calibration >    on one place (much cleaner). > > c) Having calibration on a tasklet is better since during calibration >    we can't transmit or receive (antennas are detached to measure >    noise floor), previously calibration could run in parallel with tx/rx >    and interfere (packet loss). It seems this good explanation can be mangled into the commit log entry. Luis