From: Larry Finger <Larry.Finger@lwfinger.net>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
chaoming_li@realsil.com.cn, kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] rtlwifi: rtl8192de: constify pci_device_id.
Date: Mon, 17 Jul 2017 15:14:20 -0500 [thread overview]
Message-ID: <452c5c19-b931-624e-72e4-124079b903ef@lwfinger.net> (raw)
In-Reply-To: <1500314995-3181-2-git-send-email-arvind.yadav.cs@gmail.com>
On 07/17/2017 01:09 PM, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2833 945 12 3790 ece realtek/rtlwifi/rtl8192de/sw.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2929 849 12 3790 ece realtek/rtlwifi/rtl8192de/sw.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
This applies to all 11.
Thanks,
Larry
next prev parent reply other threads:[~2017-07-17 20:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 18:09 [PATCH 00/11] constify net pci_device_id Arvind Yadav
2017-07-17 18:09 ` [PATCH 01/11] rtlwifi: rtl8192de: constify pci_device_id Arvind Yadav
2017-07-17 20:14 ` Larry Finger [this message]
2017-08-03 10:06 ` [01/11] " Kalle Valo
2017-07-17 18:09 ` [PATCH 02/11] rtlwifi: rtl8192se: " Arvind Yadav
2017-07-17 18:09 ` [PATCH 03/11] rtlwifi: rtl8821ae: " Arvind Yadav
2017-07-17 18:09 ` [PATCH 04/11] rtlwifi: rtl8723ae: " Arvind Yadav
2017-07-17 18:09 ` [PATCH 05/11] rtlwifi: rtl8723be: " Arvind Yadav
2017-07-17 18:09 ` [PATCH 06/11] rtlwifi: rtl8188ee: " Arvind Yadav
2017-07-17 18:09 ` [PATCH 07/11] rtlwifi: rtl8192ee: " Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452c5c19-b931-624e-72e4-124079b903ef@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=arvind.yadav.cs@gmail.com \
--cc=chaoming_li@realsil.com.cn \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).