linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: James Prestwood <prestwoj@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Adding CMD_SET_CHANNEL for station iftypes
Date: Fri, 19 Nov 2021 09:31:47 +0100	[thread overview]
Message-ID: <47ba74aa23a5c4fb42660d5b40e974c24acf24bf.camel@sipsolutions.net> (raw)
In-Reply-To: <2b18f86924c3d64437aa139f6401ee2e7705eeb0.camel@gmail.com>

On Thu, 2021-11-18 at 16:11 -0800, James Prestwood wrote:
> Hi,
> 
> I see CMD_SET_CHANNEL is only supported for AP-type iftypes (AP,
> P2P_GO, etc). While this definitely makes sense in most cases,
> protocols like p2p/dpp require going off channel for an undetermined
> amount of time.
> 
> I could go into the exact scenarios but in short your REMAIN_ON_CHANNEL
> could end at very inconvenient times.
> 
> Specifically when a station is not associated to any AP is there any
> harm in allowing CMD_SET_CHANNEL? Is this purely a software limitation
> or do drivers not allow this?
> 
> If this sounds reasonable (and possible)

I don't think this *works* because you don't have a way to say "I want
to now go back to idle". And sitting on a channel arbitrarily can
consume quite a bit of power.

So you'd have to add an API to cancel it again, but then realistically
we'd probably want to be able to cancel it if userspace forgets (ie.
give it a timeout), at which point it's basically equivalent to a
longer-than-you-needed remain-on-channel that you cancel after you're
done?

johannes

  reply	other threads:[~2021-11-19  8:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  0:11 Adding CMD_SET_CHANNEL for station iftypes James Prestwood
2021-11-19  8:31 ` Johannes Berg [this message]
2021-11-19 17:43   ` James Prestwood
2022-01-06 22:01     ` Johannes Berg
2022-01-07 19:35       ` James Prestwood
2022-01-09 12:00         ` Arend van Spriel
2022-01-10 17:13           ` James Prestwood
2022-02-03 22:06             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47ba74aa23a5c4fb42660d5b40e974c24acf24bf.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).