From: Govind Singh <govinds@codeaurora.org>
To: niklas.cassel@linaro.org, kvalo@codeaurora.org, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST
Date: Tue, 12 Jun 2018 18:02:48 +0530 [thread overview]
Message-ID: <47cf8ec1b11d727ea928a307a431d4a2@codeaurora.org> (raw)
In-Reply-To: <7058492257914633b55fcd423e4c0b59@aphydexm01b.ap.qualcomm.com>
On 2018-06-12 17:45, Govind Singh wrote:
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Niklas
> Cassel
> Sent: Tuesday, June 12, 2018 5:09 PM
> To: Kalle Valo <kvalo@codeaurora.org>; David S. Miller
> <davem@davemloft.net>
> Cc: Niklas Cassel <niklas.cassel@linaro.org>; netdev@vger.kernel.org;
> linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> ath10k@lists.infradead.org
> Subject: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST
>
> ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> ---
> drivers/net/wireless/ath/ath10k/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/Kconfig
> b/drivers/net/wireless/ath/ath10k/Kconfig
> index 54ff5930126c..6572a43590a8 100644
> --- a/drivers/net/wireless/ath/ath10k/Kconfig
> +++ b/drivers/net/wireless/ath/ath10k/Kconfig
> @@ -42,7 +42,8 @@ config ATH10K_USB
>
> config ATH10K_SNOC
> tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)"
> - depends on ATH10K && ARCH_QCOM
> + depends on ATH10K
> + depends on ARCH_QCOM || COMPILE_TEST
> ---help---
> This module adds support for integrated WCN3990 chip connected
> to system NOC(SNOC). Currently work in progress and will not
Thanks Niklas for enabling COMPILE_TEST. With QMI set of
changes(https://patchwork.kernel.org/patch/10448183/), we need to enable
COMPILE_TEST for
QCOM_SCM/QMI_HELPERS which seems broken today. Are you planning to fix
the same.
config QCOM_SCM
bool
- depends on ARM || ARM64
+ depends on ARM || ARM64 || COMPILE_TEST
select RESET_CONTROLLER
config QCOM_SCM_64
def_bool y
- depends on QCOM_SCM && ARM64
+ depends on QCOM_SCM && ARM64 || COMPILE_TEST
config QCOM_QMI_HELPERS
tristate
- depends on ARCH_QCOM && NET
+ depends on (ARCH_QCOM || COMPILE_TEST) && NET
-obj-$(CONFIG_ARCH_QCOM) += qcom/
+obj-y += qcom/
__qcom_scm_init/qcom_scm_call wrapper to support COMPILE_TEST.
BR,
Govind
next prev parent reply other threads:[~2018-06-12 12:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 11:39 [PATCH 1/2] ath10k: do not mix spaces and tabs in Kconfig Niklas Cassel
2018-06-12 11:39 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST Niklas Cassel
[not found] ` <7058492257914633b55fcd423e4c0b59@aphydexm01b.ap.qualcomm.com>
2018-06-12 12:32 ` Govind Singh [this message]
2018-06-12 12:44 ` FW: " Niklas Cassel
2018-06-13 8:47 ` Kalle Valo
2018-06-13 13:28 ` Niklas Cassel
2018-06-14 14:09 ` Kalle Valo
2018-06-14 18:42 ` Niklas Cassel
2018-06-12 14:50 ` [RFC PATCH] ath10k: ath10k_snoc_get_ce_id_from_irq() can be static kbuild test robot
2018-06-13 9:57 ` Kalle Valo
2018-06-12 14:50 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST kbuild test robot
2018-06-13 9:56 ` Kalle Valo
2018-07-04 9:59 ` [2/2] " Kalle Valo
[not found] ` <20180704095913.772C9606AC@smtp.codeaurora.org>
2018-07-04 11:20 ` Niklas Cassel
2018-09-03 16:59 ` [PATCH 2/2] " Kalle Valo
2018-06-14 15:18 ` [1/2] ath10k: do not mix spaces and tabs in Kconfig Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47cf8ec1b11d727ea928a307a431d4a2@codeaurora.org \
--to=govinds@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).