From: Johannes Berg <johannes@sipsolutions.net>
To: Chris Murphy <lists@colorremedies.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: 5.14-rc3 lockdep warning, iwlwifi 9560
Date: Fri, 20 Aug 2021 11:37:05 +0200 [thread overview]
Message-ID: <480c17405d7735bed3148c3085f93e3d278acadd.camel@sipsolutions.net> (raw)
In-Reply-To: <CAJCQCtSXJ5qA4bqSPY=oLRMbv-irihVvP7A2uGutEbXQVkoNaw@mail.gmail.com>
Hi Chris,
Sorry for the late reply.
> [ 17.384143] ======================================================
> [ 17.384144] WARNING: possible circular locking dependency detected
> [ 17.384146] 5.14.0-0.rc3.29.fc35.x86_64+debug #1 Not tainted
> [ 17.384147] ------------------------------------------------------
> [ 17.384148] kworker/u16:8/554 is trying to acquire lock:
> [ 17.384149] ffff91e2af7d80e8 (&sta->rate_ctrl_lock){+.-.}-{2:2},
> at: rate_control_get_rate+0xc0/0x140 [mac80211]
> [ 17.384197]
> but task is already holding lock:
> [ 17.384198] ffff91e2af7d8130 (&sta->lock){+.-.}-{2:2}, at:
> ieee80211_stop_tx_ba_cb+0x2e/0x1e0 [mac80211]
> [ 17.384229]
>
> dmesg:
> https://drive.google.com/file/d/1A5aZNMf_qXFU6arthGyu_FEIYV08V7wv/view?usp=sharing
I can confirm this is a problem, basically we have
aggregation start:
* take sta's rate lock
* call driver's rate control
* that decides to start aggregation
* calls ieee80211_start_tx_ba_session()
* takes sta lock
aggregation stop:
* ieee80211_stop_tx_ba_cb() is called
* takes sta lock
* releases TXQ from aggregation-related stop by
calling ieee80211_agg_start_txq()
* calls schedule_and_wake_txq()
* calls driver
* driver retrieves from, which calls rate control
* takes sta's rate lock
If you could, I'd appreciate if you filed a bug report on bugzilla.kernel.org (see also
https://wireless.wiki.kernel.org/en/users/drivers/iwlwifi/debugging#how_to_report
for the product/component)
It's not obvious to me immediately how to fix it, so I'd prefer to track
it as a bug report.
johannes
next prev parent reply other threads:[~2021-08-20 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 7:01 5.14-rc3 lockdep warning, iwlwifi 9560 Chris Murphy
2021-08-20 9:37 ` Johannes Berg [this message]
2021-08-21 6:22 ` Chris Murphy
2021-08-23 13:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480c17405d7735bed3148c3085f93e3d278acadd.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lists@colorremedies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).