From: Johannes Berg <johannes@sipsolutions.net>
To: vamsi krishna <vamsin@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, jouni@codeaurora.org
Subject: Re: [PATCH] nl80211/cfg80211: Add support to specify band specific min rssi thresholds with sched scan
Date: Tue, 18 Dec 2018 14:09:36 +0100 [thread overview]
Message-ID: <49850508355f57fba6f9803416bf71c24766747b.camel@sipsolutions.net> (raw)
In-Reply-To: <1543566848-14819-1-git-send-email-vamsin@codeaurora.org>
On Fri, 2018-11-30 at 14:04 +0530, vamsi krishna wrote:
>
> The drivers with capability to filter scan results with different rssi
> thresholds for different bands shall indicate the support to user space by
> setting %NL80211_EXT_FEATURE_SCHED_SCAN_BAND_SPECIFIC_RSSI_THOLD in
> wiphy->ext_features. The drivers that support this feature shall use rssi
> values from @band_specific_min_rssi_thold for scan results filtering and
> shall not use min_rssi_thold anymore.
Is there much point in this?
It seems to me that userspace will not really do anything different if
it knows what's supported - it's probably easier for it (or cfg80211?)
to just set the global min_rssi to the minimum over all bands, and treat
this as we do most things in scheduled scan - an optimisation that
doesn't really need a feature advertisement?
I think that would simplify things somewhat.
> + * @NL80211_ATTR_SCHED_SCAN_MIN_RSSI: Nested attribute that carries the band
> + * specific minimum rssi thresholds for the bands defined in enum
> + * nl80211_band. The minimum rssi threshold value(s32) specific to a band
> + * shall be encapsulated in attribute with type value equals to one of the
> + * NL80211_BAND_* defined in enum nl80211_band. For example, the minimum
> + * rssi threshold value for 2.4GHz band shall be encapsulated within an
> + * attribute of type NL80211_BAND_2GHz. And one or more of such attributes
> + * will be nested within this attribute. If min rssi sub attribute is not
> + * included for any band, then %NL80211_SCAN_RSSI_THOLD_OFF will be used
> + * as minimum rssi threshold for scan result filtering.
> + * If a scan result received in a particular band has lesser rssi than the
> + * rssi threshold specified for that band, then the scan result shall be
> + * filtered out. The rssi thresholds specified in matchsets along with ssid
> + * or bssid attribute will have higher precedence than the thresholds
> + * mentioned in this attribute while checking rssi.
It seems that this should be with the existing
NL80211_SCHED_SCAN_MATCH_ATTR_RSSI, not in this level namespace.
johannes
next prev parent reply other threads:[~2018-12-18 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 8:34 [PATCH] nl80211/cfg80211: Add support to specify band specific min rssi thresholds with sched scan vamsi krishna
2018-12-18 13:09 ` Johannes Berg [this message]
2018-12-26 9:54 ` vamsin
2019-01-15 13:25 ` Johannes Berg
2019-01-22 11:30 ` vamsin
2019-01-25 20:44 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49850508355f57fba6f9803416bf71c24766747b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jouni@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vamsin@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).