From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.redfish-solutions.com ([66.232.79.143]:33296 "EHLO mail.redfish-solutions.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbZG3EhP (ORCPT ); Thu, 30 Jul 2009 00:37:15 -0400 Message-ID: <4A71235C.40405@redfish-solutions.com> Date: Wed, 29 Jul 2009 21:36:44 -0700 From: "Philip A. Prindeville" MIME-Version: 1.0 To: Bob Copeland CC: "Luis R. Rodriguez" , linux-wireless@vger.kernel.org Subject: Re: Using compat-wireless w/ 2.6.27.26 References: <4A612514.4050708@redfish-solutions.com> <43e72e890907201247x7df76b75wf6ba2bc2260dbf7a@mail.gmail.com> <4A650331.9020409@redfish-solutions.com> <4A6620B9.4@redfish-solutions.com> <20090723112428.GC13742@hash.localnet> <4A68C821.7060208@redfish-solutions.com> <4A68DBDE.7060504@redfish-solutions.com> <4A68E80C.808@redfish-solutions.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Bob Copeland wrote: > On Thu, Jul 23, 2009 at 6:45 PM, Philip A. > Prindeville wrote: >> Bob Copeland wrote: >>> On Thu, Jul 23, 2009 at 5:53 PM, Philip A. >>> Prindeville wrote: >>>>> Getting closer :-) >>>>> >>>>> ath5k_tx_processq(sc, &sc->txqs[i]); >>>>> >>>> Didn't work with rc4: >>> What did you apply against? It's supposed to be against >>> wireless-testing (or, at worst, latest compat-wireless). >>> >>>> BUG: unable to handle kernel NULL pointer dereference at 00000000 >>>> IP: [] :ath5k:ath5k_tasklet_tx+0x5e/0x27b > >> This was against compat-wireless-2.6.31-rc4. >> >> Alas, I already blew away the build directory... > > I think you need to use the unstable compat-wireless snapshots; > I have a feeling that the above doesn't have all of the tx queues. > > Check out ath5k.h, the txq array in struct ath5k_softc should have > NUM_TX_QUEUES entries, an earlier version only had 2. > > Although your compiler generates rather different code from mine > (different config or whatever), it looks like the oops happened > in the list_for_each_entry(... txq->q ...) -- but I don't see how > that can happen in my copy, since txq[i].q is initialized at the > same time as txq[i].setup. > Give me a shout when this patch makes its way into compat-wireless-2.6.31-rcN and I'll try again with that. -Philip