Re: [PATCH 2.6.34] rtl8187: ad-hoc mode support

linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* Re: [PATCH 2.6.34] rtl8187: ad-hoc mode support
       [not found] <201007291835.46159.kirill.zut@promwad.com>
@ 2010-07-29 17:01 ` Hin-Tak Leung
  2010-07-29 18:04 ` John W. Linville
  1 sibling, 0 replies; 6+ messages in thread
From: Hin-Tak Leung @ 2010-07-29 17:01 UTC (permalink / raw)
  To: Kirill Zut
  Cc: John W. Linville, linux-wireless, Larry Finger,
	Herton Ronaldo Krzesinski

Kirill Zut wrote:
> ---
> This patch makes ad-hoc mode available on RTL8187
> 
> Signed-off-by: Kirill Zut <kirill.zut@promwad.com>

Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>

looks alright, but I remember some discussion about generic ad hoc support from 
the mac80211 is needed for all mac80211-based drivers to work. What's the status 
of that and how's it comming along?

Hin-Tak

> ---
> --- linux-2.6.x/drivers/net/wireless/rtl818x/rtl8187_dev.c.orig	2010-07-29 14:40:09.000000000 +0300
> +++ linux-2.6.x/drivers/net/wireless/rtl818x/rtl8187_dev.c	2010-07-29 14:59:39.000000000 +0300
> @@ -1032,6 +1032,7 @@ static int rtl8187_add_interface(struct 
>  
>  	switch (vif->type) {
>  	case NL80211_IFTYPE_STATION:
> +	case NL80211_IFTYPE_ADHOC:
>  		break;
>  	default:
>  		goto exit;
> @@ -1178,7 +1179,10 @@ static void rtl8187_bss_info_changed(str
>  			reg = 0;
>  
>  		if (is_valid_ether_addr(info->bssid)) {
> -			reg |= RTL818X_MSR_INFRA;
> +			if (vif->type == NL80211_IFTYPE_ADHOC)
> +				reg |= RTL818X_MSR_ADHOC;
> +			else
> +				reg |= RTL818X_MSR_INFRA;
>  			rtl818x_iowrite8(priv, &priv->map->MSR, reg);
>  		} else {
>  			reg |= RTL818X_MSR_NO_LINK;
> @@ -1502,7 +1506,8 @@ static int __devinit rtl8187_probe(struc
>  	 * XXX: Once this driver supports anything that requires
>  	 *	beacons it must implement IEEE80211_TX_CTL_ASSIGN_SEQ.
>  	 */
> -	dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
> +	dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
> +				      BIT(NL80211_IFTYPE_ADHOC);
>  
>  	if ((id->driver_info == DEVICE_RTL8187) && priv->is_rtl8187b)
>  		printk(KERN_INFO "rtl8187: inconsistency between id with OEM"
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2.6.34] rtl8187: ad-hoc mode support
       [not found] <201007291835.46159.kirill.zut@promwad.com>
  2010-07-29 17:01 ` [PATCH 2.6.34] rtl8187: ad-hoc mode support Hin-Tak Leung
@ 2010-07-29 18:04 ` John W. Linville
  2010-07-29 19:01   ` Larry Finger
  2010-07-29 19:03   ` Larry Finger
  1 sibling, 2 replies; 6+ messages in thread
From: John W. Linville @ 2010-07-29 18:04 UTC (permalink / raw)
  To: Kirill Zut
  Cc: linux-wireless, Larry Finger, Hin-Tak Leung, Herton Ronaldo Krzesinski

Don't you need something to make it beacon?

On Thu, Jul 29, 2010 at 06:35:45PM +0300, Kirill Zut wrote:
> ---
> This patch makes ad-hoc mode available on RTL8187
> 
> Signed-off-by: Kirill Zut <kirill.zut@promwad.com>
> ---
> --- linux-2.6.x/drivers/net/wireless/rtl818x/rtl8187_dev.c.orig	2010-07-29 14:40:09.000000000 +0300
> +++ linux-2.6.x/drivers/net/wireless/rtl818x/rtl8187_dev.c	2010-07-29 14:59:39.000000000 +0300
> @@ -1032,6 +1032,7 @@ static int rtl8187_add_interface(struct 
>  
>  	switch (vif->type) {
>  	case NL80211_IFTYPE_STATION:
> +	case NL80211_IFTYPE_ADHOC:
>  		break;
>  	default:
>  		goto exit;
> @@ -1178,7 +1179,10 @@ static void rtl8187_bss_info_changed(str
>  			reg = 0;
>  
>  		if (is_valid_ether_addr(info->bssid)) {
> -			reg |= RTL818X_MSR_INFRA;
> +			if (vif->type == NL80211_IFTYPE_ADHOC)
> +				reg |= RTL818X_MSR_ADHOC;
> +			else
> +				reg |= RTL818X_MSR_INFRA;
>  			rtl818x_iowrite8(priv, &priv->map->MSR, reg);
>  		} else {
>  			reg |= RTL818X_MSR_NO_LINK;
> @@ -1502,7 +1506,8 @@ static int __devinit rtl8187_probe(struc
>  	 * XXX: Once this driver supports anything that requires
>  	 *	beacons it must implement IEEE80211_TX_CTL_ASSIGN_SEQ.
>  	 */
> -	dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
> +	dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
> +				      BIT(NL80211_IFTYPE_ADHOC);
>  
>  	if ((id->driver_info == DEVICE_RTL8187) && priv->is_rtl8187b)
>  		printk(KERN_INFO "rtl8187: inconsistency between id with OEM"
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2.6.34] rtl8187: ad-hoc mode support
  2010-07-29 18:04 ` John W. Linville
@ 2010-07-29 19:01   ` Larry Finger
  2010-07-29 19:03   ` Larry Finger
  1 sibling, 0 replies; 6+ messages in thread
From: Larry Finger @ 2010-07-29 19:01 UTC (permalink / raw)
  To: John W. Linville
  Cc: Kirill Zut, linux-wireless, Hin-Tak Leung, Herton Ronaldo Krzesinski

On 07/29/2010 01:04 PM, John W. Linville wrote:
> Don't you need something to make it beacon?

Indeed he does. This code does not work. NACK.

Larry


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2.6.34] rtl8187: ad-hoc mode support
  2010-07-29 18:04 ` John W. Linville
  2010-07-29 19:01   ` Larry Finger
@ 2010-07-29 19:03   ` Larry Finger
  2010-07-29 20:52     ` Hin-Tak Leung
  1 sibling, 1 reply; 6+ messages in thread
From: Larry Finger @ 2010-07-29 19:03 UTC (permalink / raw)
  To: John W. Linville
  Cc: Kirill Zut, linux-wireless, Hin-Tak Leung, Herton Ronaldo Krzesinski

On 07/29/2010 01:04 PM, John W. Linville wrote:
> Don't you need something to make it beacon?

Indeed he does. This code allows the user to set ad-hoc mode, but I could not
establish a connection. The setup that I used worked for a b43 - b43 link, but
failed if either end used rtl8187. NACK.

Larry


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2.6.34] rtl8187: ad-hoc mode support
  2010-07-29 19:03   ` Larry Finger
@ 2010-07-29 20:52     ` Hin-Tak Leung
  2010-07-30 23:53       ` jpo
  0 siblings, 1 reply; 6+ messages in thread
From: Hin-Tak Leung @ 2010-07-29 20:52 UTC (permalink / raw)
  To: Larry Finger
  Cc: John W. Linville, Kirill Zut, linux-wireless, Herton Ronaldo Krzesinski

Larry Finger wrote:
> On 07/29/2010 01:04 PM, John W. Linville wrote:
>> Don't you need something to make it beacon?
> 
> Indeed he does. This code allows the user to set ad-hoc mode, but I could not
> establish a connection. The setup that I used worked for a b43 - b43 link, but
> failed if either end used rtl8187. NACK.

I supposed I need to withdrawn my "Ached-by:" - I was using it in the minimal 
sense of "I have seen the patch and aware of its existence".

Is the beacon code driver-specific, or is it back to my older question, some 
part of mac80211 need to have some generic support for it? or both? My 
impression is that master mode for mac80211-based drivers - if it is ever going 
to happen - requires some substantial changes to both mac80211 and hostapd and 
is not happening any time soon.

OTOH, I have the impression that the windows driver claims to support Ad-Hoc 
mode but I could be wrong - it has been a long time since I looked at the 
options and choices under windows.

Hin-Tak

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2.6.34] rtl8187: ad-hoc mode support
  2010-07-29 20:52     ` Hin-Tak Leung
@ 2010-07-30 23:53       ` jpo
  0 siblings, 0 replies; 6+ messages in thread
From: jpo @ 2010-07-30 23:53 UTC (permalink / raw)
  To: linux-wireless

Hin-Tak Leung <htl10@...> writes:
> My impression is that master mode for mac80211-based drivers - if it is ever
going 
> to happen - requires some substantial changes to both mac80211 and hostapd and 
> is not happening any time soon.

Huh? It's been there for some time now.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-07-30 23:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <201007291835.46159.kirill.zut@promwad.com>
2010-07-29 17:01 ` [PATCH 2.6.34] rtl8187: ad-hoc mode support Hin-Tak Leung
2010-07-29 18:04 ` John W. Linville
2010-07-29 19:01   ` Larry Finger
2010-07-29 19:03   ` Larry Finger
2010-07-29 20:52     ` Hin-Tak Leung
2010-07-30 23:53       ` jpo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).