linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hauke Mehrtens <hauke@hauke-m.de>
To: Kshitij Kulshreshtha <kkhere.geo@gmail.com>
Cc: linux-wireless@vger.kernel.org, lrodriguez@atheros.com
Subject: Re: compat-wireless-2010-07-28.tar.bz2 fails to compile with 2.6.34.1
Date: Sun, 01 Aug 2010 21:59:38 +0200	[thread overview]
Message-ID: <4C55D22A.5040302@hauke-m.de> (raw)
In-Reply-To: <4C5184E8.30108@gmail.com>

Am 29.07.2010 15:40, schrieb Kshitij Kulshreshtha:
> Hello,
> 
> I downloaded compat-wireless-2010-07-28.tar.bz2 from [1] and tried to
> compile it with kernel v2.6.34.1 (config attached) that is running on
> my laptop currently. Unfortunately the package failed to compile with
> several compilation errors (compilation log attached, grep for Error).
> 
> I had to apply the attached 3 patches to make it compile. Please update
> compat-wireless and compat git trees accordingly.
> 
> Thanks and regards.
> 
> [1] http://wireless.kernel.org/download/compat-wireless-2.6/

Hi Kshitij,

thank you for your patches.

Next time please inline your patches into the mail. It makes commenting
on the patch easier. See:
http://wireless.kernel.org/en/users/Download/hacking#Sending_patches

0001-hex_to_bin-was-added-first-in-2.6.35.patch:
hex_to_bin should be backported in compat. Then we do not need to add an
extra patch to compat-wireless. Patches in compat-wireless are hard to
maintain, because the wireless subsystem changes very often and the
patches have to be fixes very often.

0002-Header-file-pcmcia-cs_types.h-has-been-removed-in-2..patch:
This should also be backported in compat and not in compat-wireless. You
can add include/pcmcia/cistpl.h and include the needed file
(pcmcia/cs_types.h) and the original with #include_next <pcmcia/cistpl.h>

Hauke

  reply	other threads:[~2010-08-01 19:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 13:40 compat-wireless-2010-07-28.tar.bz2 fails to compile with 2.6.34.1 Kshitij Kulshreshtha
2010-08-01 19:59 ` Hauke Mehrtens [this message]
2010-08-01 22:02   ` [PATCH] build fixes for compat.git and compat-wireless.git Kshitij Kulshreshtha
2010-08-01 22:02   ` [PATCH 1/3] compat: backport hex_to_bin first introduced in v2.6.35 Kshitij Kulshreshtha
2010-08-01 22:02   ` [PATCH 2/3] compat: header <pcmcia/cs_types.h> was removed in v2.6.36 Kshitij Kulshreshtha
2010-08-01 22:02   ` [PATCH 3/3] compat: define struct va_format introduced " Kshitij Kulshreshtha
2010-08-02 18:00     ` Luis R. Rodriguez
2010-08-02 19:39       ` Kshitij Kulshreshtha
2010-08-02 19:48         ` Joe Perches
2010-08-02 19:54           ` Kshitij Kulshreshtha
2010-08-02 20:08             ` Joe Perches
2010-08-02 20:42               ` Luis R. Rodriguez
2010-08-01 22:02   ` [PATCH 4/5] compat-wireless: allow compilation of compat-2.6.35.c from compat Kshitij Kulshreshtha
2010-08-01 22:02   ` [PATCH 5/5] compat-wireless: copy headers in include/pcmcia " Kshitij Kulshreshtha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C55D22A.5040302@hauke-m.de \
    --to=hauke@hauke-m.de \
    --cc=kkhere.geo@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).