linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: linux-wireless@vger.kernel.org, j@w1.fi, linville@tuxdriver.com
Subject: Re: [PATCH]hostap:hostap_ioctl.c Fix variable 'ret' set but not used
Date: Mon, 02 Aug 2010 17:37:38 -0700	[thread overview]
Message-ID: <4C5764D2.2000803@gmail.com> (raw)
In-Reply-To: <AANLkTimgcFwc7FX72u5Z32DSVkL3xTEC=3vTBxHk9X6H@mail.gmail.com>

On 08/02/2010 05:16 PM, Luis R. Rodriguez wrote:
> On Mon, Aug 2, 2010 at 5:15 PM, Luis R. Rodriguez<mcgrof@gmail.com>  wrote:
>> On Mon, Aug 2, 2010 at 5:04 PM, Justin P. Mattock
>> <justinmattock@gmail.com>  wrote:
>>> The below patch fixes a warning message generated by GCC:
>>>   CC [M]  drivers/net/wireless/hostap/hostap_ioctl.o
>>> drivers/net/wireless/hostap/hostap_ioctl.c: In function 'prism2_request_scan':
>>> drivers/net/wireless/hostap/hostap_ioctl.c:1666:6: warning: variable 'ret' set but not used
>>>
>>> Keep in mind Im not sure if this is the right fix for this, so please
>>> feedback is appreciated.
>>>
>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>>
>>> ---
>>>   drivers/net/wireless/hostap/hostap_ioctl.c |    3 +--
>>>   1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/hostap/hostap_ioctl.c b/drivers/net/wireless/hostap/hostap_ioctl.c
>>> index a85e43a..27d462f 100644
>>> --- a/drivers/net/wireless/hostap/hostap_ioctl.c
>>> +++ b/drivers/net/wireless/hostap/hostap_ioctl.c
>>> @@ -1663,7 +1663,6 @@ static int prism2_request_scan(struct net_device *dev)
>>>         struct hostap_interface *iface;
>>>         local_info_t *local;
>>>         struct hfa384x_scan_request scan_req;
>>> -       int ret = 0;
>>>
>>>         iface = netdev_priv(dev);
>>>         local = iface->local;
>>> @@ -1689,7 +1688,7 @@ static int prism2_request_scan(struct net_device *dev)
>>>         if (local->func->set_rid(dev, HFA384X_RID_SCANREQUEST,&scan_req,
>>>                                  sizeof(scan_req))) {
>>>                 printk(KERN_DEBUG "SCANREQUEST failed\n");
>>> -               ret = -EINVAL;
>>> +               return -EINVAL;
>>>         }
>>>
>>>         if (!local->host_roaming)
>>
>> NACK please read the code instead of just patching blindly to cure a
>> compile issue. For example read this big block:

I suppose I did look blindly.. the whole ret = 0; then ret = *
got me.. then I figured maybe its just a return.

>>
>>
>>         /* FIX:
>>          * It seems to be enough to set roaming mode for a short moment to
>>          * host-based and then setup scanrequest data and return the mode to
>>          * firmware-based.
>>          *
>>          * Master mode would need to drop to Managed mode for a short while
>>          * to make scanning work.. Or sweep through the different channels and
>>          * use passive scan based on beacons. */
>>
>> So.. it seems to me you likely want to flip back to
>> HFA384X_ROAMING_FIRMWARE *after* you've tried to issue the
>> HFA384X_RID_SCANREQUEST, even if it has failed. So the compile fix
>> should require just changing the last return statement of the function
>> to return ret value.

so this is a simple return ret;

>
> And for 802.11 there is no need to cc netdev and lkml. Just use linux-wireless.
>
>    Luis
>

is netdev even used nowadays?
anyways I'll resend this. Thanks for the feedback and info..

Justin P. Mattock

      reply	other threads:[~2010-08-03  0:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03  0:04 [PATCH]hostap:hostap_ioctl.c Fix variable 'ret' set but not used Justin P. Mattock
2010-08-03  0:15 ` Luis R. Rodriguez
2010-08-03  0:16   ` Luis R. Rodriguez
2010-08-03  0:37     ` Justin P. Mattock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C5764D2.2000803@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).