linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Büsch" <mb@bu3sch.de>
To: stable@kernel.org, Christoph Fritz <chf.fritz@googlemail.com>,
	Larry Finger <Larry.Finger@lwfinger.net>
Cc: b43-dev <b43-dev@lists.infradead.org>,
	wireless <linux-wireless@vger.kernel.org>
Subject: ssb: 2.6.34.1 -> 2.6.34.2 regression
Date: Sat, 07 Aug 2010 00:53:06 +0200	[thread overview]
Message-ID: <4C5C9252.7040007@bu3sch.de> (raw)

Hi,

The SPROM changes applied to SSB in 2.6.34.2 completely broke SPROM
extraction. This leads to broken wireless for my BCM4306 card.
All other BCM43xx and BCM44xx most likely are affected, too.
Symptoms should be wrong MAC addresses and broken transmission (for 43xx).

The patch changed the SPEX() macro and removed the offset subtraction,
but did not remove the actual 0x1000 offset from the SPROM defines.
This results in random memory poking rather than proper SPROM data
extraction.

I applied the following to my kernel to get it working again. However
this is not a proper fix. I suggest that the -stable SSB patch
is dropped and mainline patches being applied. They seem to
be correct (However I did not test mainline, yet).


Index: linux-2.6.34/drivers/ssb/pci.c
===================================================================
--- linux-2.6.34.orig/drivers/ssb/pci.c	2010-08-05 23:26:07.000000000 +0200
+++ linux-2.6.34/drivers/ssb/pci.c	2010-08-07 00:17:26.000000000 +0200
@@ -169,7 +169,7 @@ err_pci:
  }

  /* Get the word-offset for a SSB_SPROM_XXX define. */
-#define SPOFF(offset)	((offset) / sizeof(u16))
+#define SPOFF(offset)	(((offset) - SSB_SPROM_BASE1) / sizeof(u16))
  /* Helper to extract some _offset, which is one of the SSB_SPROM_XXX 
defines. */
  #define SPEX16(_outvar, _offset, _mask, _shift)	\
  	out->_outvar = ((in[SPOFF(_offset)] & (_mask)) >> (_shift))
-- 
Greetings Michael.

             reply	other threads:[~2010-08-06 22:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-06 22:53 Michael Büsch [this message]
2010-08-06 23:56 ` [stable] ssb: 2.6.34.1 -> 2.6.34.2 regression Greg KH
2010-08-07 10:44   ` Michael Büsch
2010-08-07  6:29 ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C5C9252.7040007@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=b43-dev@lists.infradead.org \
    --cc=chf.fritz@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).