Re: [ath9k-devel] [PATCH 3/3] ath9k: Keep track of stations for debugfs.

[Ben Greear <greearb@candelatech.com>]

On 01/06/2011 06:30 PM, Luis R. Rodriguez wrote:
> On Thu, Jan 6, 2011 at 4:46 PM,<greearb@candelatech.com>  wrote:
>> +#define ATH9K_MAX_STATIONS 1024
>
> How about making this a Kconfig with a default to a value of the known
> (by you) max workable number of STAs that one can use on ath9k, which
> is modifiable to other values by power of two up to 1024. Advise in
> the kconfig that if more STAs are used then some issue may arise but
> should be reported (so the issue can be fixed). This way by default
> normal users (you're not normal) won't enable>  max known workable
> stable number of STAs on ath9k.

This is just for debugging at this point.  It wastes a bit of memory
when debugfs is enabled, but otherwise doesn't affect anything.  It's
not even really a problem if there are more stations than fit in
the array.

I can reproduce all my problems with < 128, so if you'd prefer
the number be smaller, that's fine with me.  I don't think it's
worth a configurable value, however.

Thanks,
Ben

>
>    Luis


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com