Linux-Wireless Archive on lore.kernel.org
 help / Atom feed
* [PATCH v2 0/4] rtlwifi: Fix issues with rtl8723ae
@ 2019-01-05 18:38 Bernd Edlinger
  2019-01-05 21:34 ` Larry Finger
  0 siblings, 1 reply; 2+ messages in thread
From: Bernd Edlinger @ 2019-01-05 18:38 UTC (permalink / raw)
  To: Ping-Ke Shih, Larry Finger, Kalle Valo, David S. Miller,
	linux-wireless, netdev, linux-kernel

Currently the rtl8723ae driver is broken (since v4.7).

Connection to AP is lost very often, especially when
the signal level is not very good.

The main issue is the power save mode is basically
not working, and seems to trigger a firmware bug.
So I had to take out the FW LPS mode handling.

While debugging the driver I found a couple related issues,
for instance that the signal level in dm.undec_sm_pwdb
is no longer accurate (may be even much too high) when no more
packets are received, and it increases the likelihood to receive
something if the input gain is set to maximum.

The patch was tested with the rtl8723ae PCI card in my laptop
against a FRITZ!Box 7590 AP -- the WiFi connection works now
very reliable for me.

V2 of the patch adjusts the defaults of swlps and fwlps module
parameters to match the firmware capabilities instead of removing
the whole code, so it can be easily re-activated once a firmware
update is available.


Bernd Edlinger (4):
  rtlwifi: rtl8723ae: Take the FW LPS mode handling out
  rtlwifi: rtl8723ae: Don't use dm.undec_sm_pwdb for input gain control 
       when no beacon was received in the connected state
  rtlwifi: rtl8723ae: Re-introduce
    rtl8723e_dm_refresh_rate_adaptive_mask
  rtlwifi: Move the clearing of rtlpriv->link_info.num_rx_inperiod in   
     rtl_watchdog_wq_callback a few lines down

 drivers/net/wireless/realtek/rtlwifi/base.c        |  4 +-
 drivers/net/wireless/realtek/rtlwifi/core.c        |  2 +
 .../net/wireless/realtek/rtlwifi/rtl8723ae/dm.c    | 95 +++++++++++++++++++++-
 .../net/wireless/realtek/rtlwifi/rtl8723ae/sw.c    |  8 +-
 4 files changed, 101 insertions(+), 8 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 0/4] rtlwifi: Fix issues with rtl8723ae
  2019-01-05 18:38 [PATCH v2 0/4] rtlwifi: Fix issues with rtl8723ae Bernd Edlinger
@ 2019-01-05 21:34 ` Larry Finger
  0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2019-01-05 21:34 UTC (permalink / raw)
  To: Bernd Edlinger, Ping-Ke Shih, Kalle Valo, David S. Miller,
	linux-wireless, netdev, linux-kernel

On 1/5/19 12:38 PM, Bernd Edlinger wrote:
> Currently the rtl8723ae driver is broken (since v4.7).
> 
> Connection to AP is lost very often, especially when
> the signal level is not very good.
> 
> The main issue is the power save mode is basically
> not working, and seems to trigger a firmware bug.
> So I had to take out the FW LPS mode handling.
> 
> While debugging the driver I found a couple related issues,
> for instance that the signal level in dm.undec_sm_pwdb
> is no longer accurate (may be even much too high) when no more
> packets are received, and it increases the likelihood to receive
> something if the input gain is set to maximum.
> 
> The patch was tested with the rtl8723ae PCI card in my laptop
> against a FRITZ!Box 7590 AP -- the WiFi connection works now
> very reliable for me.
> 
> V2 of the patch adjusts the defaults of swlps and fwlps module
> parameters to match the firmware capabilities instead of removing
> the whole code, so it can be easily re-activated once a firmware
> update is available.
> 
> 
> Bernd Edlinger (4):
>    rtlwifi: rtl8723ae: Take the FW LPS mode handling out
>    rtlwifi: rtl8723ae: Don't use dm.undec_sm_pwdb for input gain control
>         when no beacon was received in the connected state
>    rtlwifi: rtl8723ae: Re-introduce
>      rtl8723e_dm_refresh_rate_adaptive_mask
>    rtlwifi: Move the clearing of rtlpriv->link_info.num_rx_inperiod in
>       rtl_watchdog_wq_callback a few lines down

The subject on all 4 of these need to be modified. Only the first line will be 
shown as the "subject", which will not make much sense.

In addition, you need to include the changes in the cover letter, and in the 
actual patch after the --- line. In that section, you mention what changes were 
made in each revision, then follow with another --- line. That info is there for 
the maintainers - it will be stripped before the patch is merged.

Larry


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-05 18:38 [PATCH v2 0/4] rtlwifi: Fix issues with rtl8723ae Bernd Edlinger
2019-01-05 21:34 ` Larry Finger

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox