Re: [PATCH] iwlwifi: eeprom-parse: use struct_size() in kzalloc()

From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Luciano Coelho <luciano.coelho@intel.com>,
	Johannes Berg <johannes.berg@intel.com>,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	Intel Linux Wireless <linuxwifi@intel.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: eeprom-parse: use struct_size() in kzalloc()
Date: Tue, 29 Jan 2019 10:36:46 -0600	[thread overview]
Message-ID: <4ecfc417-350d-4078-8ac4-3f79fd279413@embeddedor.com> (raw)
In-Reply-To: <ab42883662302f80629f00f1c5512f7deb5a2abf.camel@intel.com>

On 1/22/19 4:58 AM, Luciano Coelho wrote:
> On Tue, 2019-01-08 at 11:17 -0600, Gustavo A. R. Silva wrote:
>> One of the more common cases of allocation size calculations is
>> finding the
>> size of a structure that has a zero-sized array at the end, along
>> with memory
>> for some number of elements for that array. For example:
>>
>> struct foo {
>>     int stuff;
>>     void *entry[];
>> };
>>
>> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count,
>> GFP_KERNEL);
>>
>> Instead of leaving these open-coded and prone to type mistakes, we
>> can now
>> use the new struct_size() helper:
>>
>> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
> 
> Applied to our internal tree, thanks! It will reach the mainline
> following our normal upstreaming process.
> 

Great. :)

Thanks, Luca.

--
Gustavo