From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dev-nolb.cloudtrax.com ([54.203.245.161]:56412 "EHLO dev-nolb.cloudtrax.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbaENVLD (ORCPT ); Wed, 14 May 2014 17:11:03 -0400 Message-ID: <5373DB83.2080006@open-mesh.com> (sfid-20140514_231107_339484_28016F97) Date: Wed, 14 May 2014 23:09:23 +0200 From: Antonio Quartulli MIME-Version: 1.0 To: Johannes Berg , Antonio Quartulli CC: b.a.t.m.a.n@lists.open-mesh.org, linux-wireless@vger.kernel.org, devel@lists.open80211s.org Subject: Re: [PATCH 2/7] mac80211: add get_expected_throughput API References: <1397484205-20905-1-git-send-email-antonio@meshcoding.com> <1397484205-20905-2-git-send-email-antonio@meshcoding.com> <1398440696.4152.26.camel@jlt4.sipsolutions.net> In-Reply-To: <1398440696.4152.26.camel@jlt4.sipsolutions.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ORNF4T3Ao6Kb63UtdaHlwbCU0hE1I7DmI" Sender: linux-wireless-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ORNF4T3Ao6Kb63UtdaHlwbCU0hE1I7DmI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 25/04/14 17:44, Johannes Berg wrote: > On Mon, 2014-04-14 at 16:03 +0200, Antonio Quartulli wrote: >=20 >> + u32 (*get_expected_throughput)(struct ieee80211_sta *sta); >=20 > This isn't nice - it forces drivers to conjure up a value. >=20 > You should probably at least allow returning 0 for "no idea" or > something. Yeah, I think so too. Returning 0 as "I don't know what to provide" should be fine. I will specify this in the doc. Cheers, --=20 Antonio Quartulli --ORNF4T3Ao6Kb63UtdaHlwbCU0hE1I7DmI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJTc9uLAAoJEEKTMo6mOh1Vfr4P/0n0mFbSxtiUpVl1EQ6dBUct +G3Qs1ToZQNQHrqzynWNEc/XIhFZBLX86aYHN8g1jF3ngbDPcbmt/gtSrt/CRZ6P uifzzAJVbPmN7kWSoU97CtFGrB06lL2jiG2NIflrwl0qbL7/4lphE4KY8Mm8vdWa 45FLAEOvtsO8D6R0YDaNlNFtSAlCopZ0UNcllzoW8bgodoXbfN7ClrM1sIkiJ9gy aTDI9+C6qNJV8rw3tyxhczuo2VGVGvORExpldwIemogX12lsx2j2zQ7seP7tP/MW +XHM7wW2XQbBGNHIIEoNV8ultU4MCeJsozIXxnqPVnmgY43yx/rx9LqvhFECQVdZ XFAoStiboR9cQtDXtHvI/U3Nc40npOIbwL40r1IPV4MlDBUk8dgP1Ji33Ls/uVRQ 89IG+EMPDh2QD0LfrBcfQku9HLjqQ0A6wdO0wLfwPU/U0Cdr6iBdjCaUzbe4BNfn romgB8B8f7lEn3ClKLEHpXBOttuNA3VXYxHoZ01H64l0p4h7aZSkbJ9FcDKATi8s Gf67rE71NHwISPSQMbo/MwZ97SmIEdwERlgX730OGAGTVa/FV+LNpO5XSCBKfCBX BsyFTDtOhlpS6E2vGKquN6ENUWLaFrGe+7Wtffz5h8EjCDj0xmA5cL/Dy/ScUYTC 8wVj62CWtkfAg2LQWz/F =TpMe -----END PGP SIGNATURE----- --ORNF4T3Ao6Kb63UtdaHlwbCU0hE1I7DmI--