From: Arend van Spriel <arend@broadcom.com>
To: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
Cc: "brudley@broadcom.com" <brudley@broadcom.com>,
Franky Lin <frankyl@broadcom.com>,
"meuleman@broadcom.com" <meuleman@broadcom.com>,
Kalle Valo <kvalo@codeaurora.org>,
"pieterpg@broadcom.com" <pieterpg@broadcom.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211-dev-list@broadcom.com"
<brcm80211-dev-list@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] brcmfmac: prohibit ACPI power management for brcmfmac driver
Date: Wed, 20 May 2015 11:02:33 +0200 [thread overview]
Message-ID: <555C4DA9.8020600@broadcom.com> (raw)
In-Reply-To: <55598622.8060307@linux.intel.com>
On 05/18/15 08:26, Fu, Zhonghui wrote:
>
> Hi guys,
>
> Any comments about this patch?
My acked is already there. I have not been able to test it, but I assume
you did.
Regards,
Arend
> Thanks,
> Zhonghui
>
> On 2015/5/11 10:41, Fu, Zhonghui wrote:
>> ACPI will manage WiFi chip's power state during suspend/resume
>> process on some tablet platforms(such as ASUS T100TA). This is
>> not supported by brcmfmac driver now, and the context of WiFi
>> chip will be damaged after resume. This patch informs ACPI not
>> to manage WiFi chip's power state.
>>
>> Signed-off-by: Zhonghui Fu<zhonghui.fu@linux.intel.com>
>> Acked-by: Arend van Spriel<arend@broadcom.com>
>> ---
>> Changes in v3:
>> - Have the assignment separate for the if statement.
>>
>> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 9 +++++++++
>> 1 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
>> index 9b508bd..c960a12 100644
>> --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
>> +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
>> @@ -33,6 +33,7 @@
>> #include<linux/suspend.h>
>> #include<linux/errno.h>
>> #include<linux/module.h>
>> +#include<linux/acpi.h>
>> #include<net/cfg80211.h>
>>
>> #include<defs.h>
>> @@ -1114,6 +1115,8 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func,
>> int err;
>> struct brcmf_sdio_dev *sdiodev;
>> struct brcmf_bus *bus_if;
>> + struct device *dev;
>> + struct acpi_device *adev;
>>
>> brcmf_dbg(SDIO, "Enter\n");
>> brcmf_dbg(SDIO, "Class=%x\n", func->class);
>> @@ -1121,6 +1124,12 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func,
>> brcmf_dbg(SDIO, "sdio device ID: 0x%04x\n", func->device);
>> brcmf_dbg(SDIO, "Function#: %d\n", func->num);
>>
>> + /* prohibit ACPI power management for this device */
>> + dev =&func->dev;
>> + adev = ACPI_COMPANION(dev);
>> + if (adev)
>> + adev->flags.power_manageable = 0;
>> +
>> /* Consume func num 1 but dont do anything with it. */
>> if (func->num == 1)
>> return 0;
>> -- 1.7.1
>>
>
next prev parent reply other threads:[~2015-05-20 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 2:41 [PATCH v3] brcmfmac: prohibit ACPI power management for brcmfmac driver Fu, Zhonghui
2015-05-18 6:26 ` Fu, Zhonghui
2015-05-20 9:02 ` Arend van Spriel [this message]
2015-05-26 3:52 ` Fu, Zhonghui
2015-05-26 10:46 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555C4DA9.8020600@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pieterpg@broadcom.com \
--cc=zhonghui.fu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).