From: Arend van Spriel <arend@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Hante Meuleman <meuleman@broadcom.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: Re: [PATCH 6/6] brcmfmac: Add support for host platform NVRAM loading.
Date: Fri, 22 May 2015 11:20:16 +0200 [thread overview]
Message-ID: <555EF4D0.3070302@broadcom.com> (raw)
In-Reply-To: <CACna6rx3PK9SH44BUDqKTWcWkvpVeGSfbL5Jm31Zj26O=8KK-Q@mail.gmail.com>
On 05/22/15 11:05, Rafał Miłecki wrote:
> On 22 May 2015 at 10:31, Arend van Spriel<arend@broadcom.com> wrote:
>> On 05/20/15 17:02, Rafał Miłecki wrote:
>>>
>>> On 20 May 2015 at 14:09, Arend van Spriel<arend@broadcom.com> wrote:
>>>>
>>>> @@ -139,11 +165,11 @@ brcmf_nvram_handle_value(struct nvram_parser *nvp)
>>>> char *ekv;
>>>> u32 cplen;
>>>>
>>>> - c = nvp->fwnv->data[nvp->pos];
>>>> - if (!is_nvram_char(c)) {
>>>> + c = nvp->data[nvp->pos];
>>>> + if (!is_nvram_char(c)&& (c != ' ')) {
>>>
>>>
>>> Don't smuggle behavior changes in patches doing something else!
>>
>>
>> The subject is "Add support for host platform NVRAM loading" and guess what.
>> That type of NVRAM turned out to have spaces in the entries so in my opinion
>> it is related to this patch. I can split it up if you feel strongly about
>> this.
>
> I'd expect such patch to just implement *loading* from different
> source and nothing else. If there are additional changes needed, I
> think they should go in separated patch if possible.
>
> I noticed the same problem with parsing NVRAM values and sent
> [PATCH] brcmfmac: allow NVRAM values to contain space and '#' chars
> , so you should be able to drop this patch of your patch anyway.
> You may give me an Ack if you have a moment :)
Whoops. I did not :-p I don't want to deal with '#' in value field as it
is either invalid or irrelevant to firmware on the device.
Regards,
Arend
>>>> @@ -406,19 +434,34 @@ static void brcmf_fw_request_nvram_done(const
>>>> struct firmware *fw, void *ctx)
>>>> struct brcmf_fw *fwctx = ctx;
>>>> u32 nvram_length = 0;
>>>> void *nvram = NULL;
>>>> + u8 *data = NULL;
>>>> + size_t data_len;
>>>> + bool raw_nvram;
>>>>
>>>> brcmf_dbg(TRACE, "enter: dev=%s\n", dev_name(fwctx->dev));
>>>> - if (!fw&& !(fwctx->flags& BRCMF_FW_REQ_NV_OPTIONAL))
>>>> - goto fail;
>>>> + if ((fw)&& (fw->data)) {
>>>
>>>
>>> if (fw&& fw->data)
>>> will work just fine, I'm surprised checkpatch doesn't complain.
>>
>> I ran checkpatch.pl --strict and did not get complaint about this change.
>
> I know, it's weird. Maybe I'll report this an improvement idea to
> checkpatch maintainer.
>
prev parent reply other threads:[~2015-05-22 9:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 12:09 [PATCH 0/6] brcmfmac: PCIe changes and NVRAM support Arend van Spriel
2015-05-20 12:09 ` [PATCH 1/6] brcmfmac: allow device tree node without 'interrupts' property Arend van Spriel
2015-05-26 11:10 ` [1/6] " Kalle Valo
2015-05-20 12:09 ` [PATCH 2/6] brcmfmac: Improve throughput by scheduling msbug flow worker Arend van Spriel
2015-05-20 12:09 ` [PATCH 3/6] brcmfmac: remove pci shared structure rev4 support Arend van Spriel
2015-05-20 12:09 ` [PATCH 4/6] brcmfmac: remove dummy cache flush/invalidate function Arend van Spriel
2015-05-20 12:09 ` [PATCH 5/6] brcmfmac: add support for dma indices feature Arend van Spriel
2015-05-20 12:09 ` [PATCH 6/6] brcmfmac: Add support for host platform NVRAM loading Arend van Spriel
2015-05-20 14:33 ` Rafał Miłecki
2015-05-21 8:28 ` Rafał Miłecki
2015-05-21 9:28 ` Arend van Spriel
2015-05-21 9:30 ` Arend van Spriel
2015-05-21 9:32 ` Rafał Miłecki
2015-05-21 10:16 ` Kalle Valo
2015-05-21 10:30 ` Arend van Spriel
2015-05-21 14:08 ` Kalle Valo
2015-05-20 15:02 ` Rafał Miłecki
2015-05-22 8:31 ` Arend van Spriel
2015-05-22 9:05 ` Rafał Miłecki
2015-05-22 9:20 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555EF4D0.3070302@broadcom.com \
--to=arend@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).