From: Johannes Berg <johannes@sipsolutions.net>
To: Ajay.Kathat@microchip.com, kvalo@kernel.org
Cc: linux-wireless@vger.kernel.org, Claudiu.Beznea@microchip.com,
Sripad.Balwadgi@microchip.com
Subject: Re: [PATCH 3/5] wilc1000: fix crash observed in AP mode with cfg80211_register_netdevice()
Date: Mon, 09 May 2022 21:44:40 +0200 [thread overview]
Message-ID: <57cb3e2f1ba75aec472ca5cfdcd8fc3c7ffffeb0.camel@sipsolutions.net> (raw)
In-Reply-To: <aeafb6e2-d294-475b-1c43-1f90bf8d5114@microchip.com>
On Mon, 2022-05-09 at 13:49 +0000, Ajay.Kathat@microchip.com wrote:
>
> As I understand, in WILC "ieee80211_ptr" is used for the station/AP
> interface but not to configure the monitor interface which gets
> additionally added in AP mode. In AP mode, for an interface( wlan0 ), an
> additional monitor interface( mon.wlan0 ) gets created. A netdevice is
> register for monitor interface(mon.wlan0) to transmit/receive frames
> from/to hostapd. That interface doesn't explicitly set up
> 'ieee80211_ptr' because the original interface(wlan0) uses it, so using
> "cfg80211_register/unregister" API's for mon.wlan0 interfaces fails.
Btw, this probably should just be removed in favour of using the nl80211
based APIs for hostapd ...
But I think as a quick bugfix goes this is fine, but it'd be better to
remove this and either allow hostapd to create the interface with the
proper ieee80211_ptr, or to just use the nl80211-based TX/RX.
johannes
next prev parent reply other threads:[~2022-05-09 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 16:19 [PATCH 1/5] wilc1000: increase firmware version array size Ajay.Kathat
2022-05-04 16:19 ` [PATCH 2/5] wilc1000: use fixed function base register value to access SDIO_FBR_ENABLE_CSA Ajay.Kathat
2022-05-04 16:19 ` [PATCH 4/5] wilc1000: use 'u64' datatype for cookie variable Ajay.Kathat
2022-05-04 16:19 ` [PATCH 3/5] wilc1000: fix crash observed in AP mode with cfg80211_register_netdevice() Ajay.Kathat
2022-05-09 11:50 ` Kalle Valo
2022-05-09 13:49 ` Ajay.Kathat
2022-05-09 19:44 ` Johannes Berg [this message]
2022-05-10 9:55 ` Ajay.Kathat
2022-05-11 4:41 ` Kalle Valo
2022-05-04 16:19 ` [PATCH 5/5] wilc1000: add valid vmm_entry check before fetching from TX queue Ajay.Kathat
2022-05-11 5:25 ` [PATCH 1/5] wilc1000: increase firmware version array size Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57cb3e2f1ba75aec472ca5cfdcd8fc3c7ffffeb0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Ajay.Kathat@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Sripad.Balwadgi@microchip.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).