From: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To: "kevin@kevinlocke.name" <kevin@kevinlocke.name>
Cc: linuxwifi <linuxwifi@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Coelho, Luciano" <luciano.coelho@intel.com>
Subject: Re: [linuxwifi] [RFC] iwlwifi: enable TX AMPDU for some iwldvm
Date: Tue, 12 Mar 2019 20:48:42 +0000 [thread overview]
Message-ID: <58bd45ab11912eef5c809427449a31800ecdbf53.camel@intel.com> (raw)
In-Reply-To: <20190312203101.GA19902@kevinolos>
On Tue, 2019-03-12 at 14:31 -0600, Kevin Locke wrote:
> Thanks Luca and Emmanuel,
>
> On Tue, 2019-03-12 at 19:47 +0000, Grumbach, Emmanuel wrote:
> > On Tue, 2019-03-12 at 21:38 +0200, Luciano Coelho wrote:
> > > If this feature was explicitly disabled, it certainly means that
> > > something was causing problems with it, so I'd be wary to enable
> > > it
> > > for all DVM devices.
> > >
> > > I guess we could enable it by default for devices that work fine,
> > > but
> > > we would have to run it in real life for a lot longer with a lot
> > > more
> > > different APs to be sure it won't cause any problems.
>
> Makes sense to me. I can start testing with available APs. Let me
> know if there is anything specific I should look for or catalog
> beyond
> latency, packet drop rates, and bandwidth.
>
> > > Emmanuel, do you happen to remember what was the issue, so Kevin
> > > could test that specific scenario with this specific NIC?
> >
> > long long nights of despair.
> >
> > We had issues with reclaim path upon BACK. This is of course a
> > firmware
> > problem...
>
> Does that suggest the issue may have been fixed by a firmware update?
> For reference, I'm currently using "firmware version 9.221.4.1 build
> 25532" from the firmware-iwlwifi Debian package (version 20190114-1).
>
> If it would be helpful, I could attempt to bisect the firmware
> revisions to find the one that fixed it (assuming I can reproduce the
> issue with a previous firmware version).
Well.. Sorry, I wasn't very "technical".
So the problem was really that we stopped getting BACK notifications
from the firmware and that caused a reclaim stall which in turn was
caught by a Tx queue stuck timer firing in the driver.
I was never able to reproduce this. What I can do is to enable A-MPDU
on my old system that has this same device, just to see what happens.
While chasing this bug, I even found another one which bought me a few
moments of fame:
commit d6ee27eb13beab94056e0de52d81220058ca2297
Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Date: Wed Jun 6 09:13:36 2012 +0200
iwlwifi: don't mess up the SCD when removing a key
and in the commit message of that very commit:
This doesn't seem to fix the higher queues that get stuck
from time to time.
There were no new versions of the firmware released since then.
I tried to skim through bugzilla, but couldn't find the bugs I was
handling then.
>
> Thanks again,
> Kevin
next prev parent reply other threads:[~2019-03-12 20:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 17:12 [RFC] iwlwifi: enable TX AMPDU for some iwldvm Kevin Locke
2019-03-12 19:38 ` [linuxwifi] " Luciano Coelho
2019-03-12 19:47 ` Grumbach, Emmanuel
2019-03-12 20:31 ` Kevin Locke
2019-03-12 20:48 ` Grumbach, Emmanuel [this message]
2019-03-12 21:44 ` Kevin Locke
2019-03-13 4:58 ` Grumbach, Emmanuel
2019-03-13 15:06 ` Kevin Locke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58bd45ab11912eef5c809427449a31800ecdbf53.camel@intel.com \
--to=emmanuel.grumbach@intel.com \
--cc=kevin@kevinlocke.name \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).