From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from mail-qt0-f182.google.com ([209.85.216.182]:33954 "EHLO
        mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751693AbdG0J4k (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Thu, 27 Jul 2017 05:56:40 -0400
Received: by mail-qt0-f182.google.com with SMTP id s6so69813685qtc.1
        for <linux-wireless@vger.kernel.org>; Thu, 27 Jul 2017 02:56:40 -0700 (PDT)
Message-ID: <5979B8D4.8080003@broadcom.com> (sfid-20170727_115644_861607_3A624775)
Date: Thu, 27 Jul 2017 11:56:36 +0200
From: Arend van Spriel <arend.vanspriel@broadcom.com>
MIME-Version: 1.0
To: Kalle Valo <kvalo@codeaurora.org>
CC: Larry Finger <Larry.Finger@lwfinger.net>,
        linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
        Yan-Hsuan Chuang <yhchuang@realtek.com>,
        Birming Chiu <birming@realtek.com>,
        Shaofu <shaofu@realtek.com>, Steven Ting <steventing@realtek.com>
Subject: Re: [PATCH v4 01/10] rtlwifi: Fill in_4way field by driver
References: <20170702181239.17911-1-Larry.Finger@lwfinger.net>        <20170702181239.17911-2-Larry.Finger@lwfinger.net> <874ltyxl1b.fsf@purkki.adurom.net>
In-Reply-To: <874ltyxl1b.fsf@purkki.adurom.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On 7/27/2017 11:54 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
>
>> From: Ping-Ke Shih <pkshih@realtek.com>
>>
>> Because it isn't always correct to use EAPOL to check 4-way,
>> we add a timer to handle exception.
>>
>> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
>> Cc: Birming Chiu <birming@realtek.com>
>> Cc: Shaofu <shaofu@realtek.com>
>> Cc: Steven Ting <steventing@realtek.com>
>
> [...]
>
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
>> @@ -1408,6 +1408,11 @@ u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx,
>>
>>   		return true;
>>   	} else if (ETH_P_PAE == ether_type) {
>> +		/* EAPOL is seens as in-4way */
>> +		rtlpriv->btcoexist.btc_info.in_4way = true;
>> +		rtlpriv->btcoexist.btc_info.in_4way_ts = jiffies;
>> +	rtlpriv->btcoexist.btc_info.in_4way_ts = jiffies;
>> +
>>   		RT_TRACE(rtlpriv, (COMP_SEND | COMP_RECV), DBG_DMESG,
>>   			 "802.1X %s EAPOL pkt!!\n", (is_tx) ? "Tx" : "Rx");
>
> The indentation looks wrong.

That wrongly indented line seems a bit redundant anyway :-p

Regards,
Arend