linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Chaoming Li <chaoming_li@realsil.com.cn>,
	Kalle Valo <kvalo@codeaurora.org>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Masanari Iida <standby24x7@gmail.com>,
	linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8821ae: Fix HW_VAR_NAV_UPPER operation
Date: Fri, 14 Jul 2017 14:09:46 -0500	[thread overview]
Message-ID: <5992b195-2ebb-a620-3324-ca2d689e11a7@lwfinger.net> (raw)
In-Reply-To: <20170713074323.r7rjpnp6ghrdtjgx@mwanda>

On 07/13/2017 02:43 AM, Dan Carpenter wrote:
> The cast here is wrong.  We want to cast the pointer but we accidentally
> do a no-op cast of the value.  We normally want to set us_nav_upper to
> WIFI_NAV_UPPER_US (30000) but because of this bug we instead set it to
> 184 on little endian systems and 0 on big endian ones.
> 
> Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks for catching this error. I suspect a typo, but your fix is obviously correct.

Does the "Fixes" notation imply a Cc to stable? If not, then the patch needs a 
Cc to stable for 3.14+.

Thanks again,

Larry

  reply	other threads:[~2017-07-14 19:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13  7:43 [PATCH] rtlwifi: rtl8821ae: Fix HW_VAR_NAV_UPPER operation Dan Carpenter
2017-07-14 19:09 ` Larry Finger [this message]
2017-07-15  7:40   ` Dan Carpenter
2017-07-28 15:43 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5992b195-2ebb-a620-3324-ca2d689e11a7@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=chaoming_li@realsil.com.cn \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=standby24x7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).