From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:43679 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756279Ab0HKT1w convert rfc822-to-8bit (ORCPT ); Wed, 11 Aug 2010 15:27:52 -0400 From: "DebBarma, Tarun Kanti" To: "felipe.balbi@nokia.com" CC: Ohad Ben-Cohen , "linux-wireless@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-omap@vger.kernel.org" , Ido Yariv , Mark Brown , "linux-arm-kernel@lists.infradead.org" , "Chikkature Rajashekar, Madhusudhan" , "Coelho Luciano (Nokia-MS/Helsinki)" , "akpm@linux-foundation.org" , San Mehat , "Quadros Roger (Nokia-MS/Helsinki)" , Tony Lindgren , Nicolas Pitre , "Pandita, Vikram" , Kalle Valo Date: Thu, 12 Aug 2010 00:57:18 +0530 Subject: RE: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data Message-ID: <5A47E75E594F054BAF48C5E4FC4B92AB0324110AC7@dbde02.ent.ti.com> References: <1281550913-17633-1-git-send-email-ohad@wizery.com> <1281550913-17633-4-git-send-email-ohad@wizery.com> <5A47E75E594F054BAF48C5E4FC4B92AB0324110ABD@dbde02.ent.ti.com> <20100811184742.GA21778@nokia.com> <5A47E75E594F054BAF48C5E4FC4B92AB0324110AC1@dbde02.ent.ti.com> <20100811185724.GD21778@nokia.com> In-Reply-To: <20100811185724.GD21778@nokia.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi@nokia.com] > Sent: Thursday, August 12, 2010 12:27 AM > To: DebBarma, Tarun Kanti > Cc: Balbi Felipe (Nokia-MS/Helsinki); Ohad Ben-Cohen; linux- > wireless@vger.kernel.org; linux-mmc@vger.kernel.org; linux- > omap@vger.kernel.org; Ido Yariv; Mark Brown; linux-arm- > kernel@lists.infradead.org; Chikkature Rajashekar, Madhusudhan; Coelho > Luciano (Nokia-MS/Helsinki); akpm@linux-foundation.org; San Mehat; Quadros > Roger (Nokia-MS/Helsinki); Tony Lindgren; Nicolas Pitre; Pandita, Vikram; > Kalle Valo > Subject: Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get > board data > > Hi, > > On Wed, Aug 11, 2010 at 08:52:54PM +0200, ext DebBarma, Tarun Kanti wrote: > >True; however if we go by that argument than we can also assume pdata > >is valid, so that we would not need the below check. > > of course not. You can have devices that just play well with default > values or devices where you don't need the flexibility of platform data. > That's why we check. > > platform_device pointers on the other hand, are guaranteed to be always > true, if it isn't then you should oops, you deserve to oops because > something is really really wrong. > Sounds perfect! What that means is _probe() function makes sense only for cases where we have valid platform data because we are returning right at the top if pdata is not valid. If this is the case I was curious to know why not framework make another check for valid pdata before calling _probe() instead of coming all the way to _probe() and then returning! > >Still, I would go ahead and find out if there is any scenario where > >pdev can go wrong during device registration. Thanks. > > if that scenario ever happens, it's either a bug on your implementation > or driver-core. In both cases you deserve to oops so we catch such > problems at early stages. > > -- > balbi > > DefectiveByDesign.org