From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F28FC3A59E for ; Wed, 21 Aug 2019 21:15:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F73520644 for ; Wed, 21 Aug 2019 21:15:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="h0eEkX/E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730796AbfHUVPW (ORCPT ); Wed, 21 Aug 2019 17:15:22 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:37344 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729594AbfHUVPW (ORCPT ); Wed, 21 Aug 2019 17:15:22 -0400 Received: from [172.31.98.117] (unknown [4.30.140.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 92E8665934; Wed, 21 Aug 2019 14:15:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 92E8665934 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1566422121; bh=B4Y9XTKNmDEmozuFGDcpQRF554bmUwrrknXc8d037DE=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=h0eEkX/EY5kFm3OEwJ0SS9Q09CploYy0KVfBi0HpfI+mL3fTKFVC+3mWXSPJj02ab E9d88JrZ7oYWRrKQ+19Kg9v+g8zG8jlJUnFB59fq5rge3czn9sQbmaSeIq1wh+K9v/ 2Oz1Z11il+xkc30VNIFmZ06pxuKG+V6Q5Et0Ok+M= Message-ID: <5D5DB467.4000007@candelatech.com> Date: Wed, 21 Aug 2019 14:15:19 -0700 From: Ben Greear Organization: Candela Technologies User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Rakesh Pillai CC: ath10k , linux-wireless@vger.kernel.org Subject: Re: Regression with commit "ath10k: fill the channel survey results for WCN3990 correctly" References: <5D5DAFE4.6080706@candelatech.com> <5D5DB246.7040402@candelatech.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Looks like it should work. Why is this rotting in patchwork? Thanks Ben On 08/21/2019 02:12 PM, Rakesh Pillai wrote: > Hi Ben, > Can you please check https://patchwork.kernel.org/patch/10844513/ ? > This change fixes the below mentioned regression. A different structure is made for tlv specific event handling. > > Thanks, > Rakesh Pillai. > > > On 2019-08-21 14:06, Ben Greear wrote: >> On 08/21/2019 01:56 PM, Ben Greear wrote: >>> Hello, >>> >>> I just noticed in 5.2.7+ kernel than this commit below appears to break WMI >>> message for my 10.1 firmware, and based on code inspection, 10.2 will be broken >>> as well. >>> >>> 10.1 struct ends with cycle_count, and 10.2 ends with one 32-bit number >>> after that, but which is not chan_tx_pwr_range. >>> >>> I guess you need to create your own wmi msg for the WCN3990. >>> >>> The change to 10.4 chan_info event is also wrong for my relatively >>> new version of 10.4 code, so likely breaks firmware in use. last member >>> in that struct in my 10.4 fw src is 'A_UINT32 rx_11b_mode_data_duration;' >> >> Sorry, I mis-read this 10.4 part of the patch, it was not changing the wmi event >> itself, so probably that part is fine. >> >> Thanks, >> Ben >> >>> >>> >>> commit 13104929d2ec32aec0552007d55b9e15bc07176b >>> Author: Rakesh Pillai >>> Date: Wed Oct 17 16:50:03 2018 +0530 >>> >>> ath10k: fill the channel survey results for WCN3990 correctly >>> >>> >>> >>> diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h >>> index 4971d61..58e33ab 100644 >>> --- a/drivers/net/wireless/ath/ath10k/wmi.h >>> +++ b/drivers/net/wireless/ath/ath10k/wmi.h >>> @@ -6442,6 +6442,14 @@ struct wmi_chan_info_event { >>> __le32 noise_floor; >>> __le32 rx_clear_count; >>> __le32 cycle_count; >>> + __le32 chan_tx_pwr_range; >>> + __le32 chan_tx_pwr_tp; >>> + __le32 rx_frame_count; >>> + __le32 my_bss_rx_cycle_count; >>> + __le32 rx_11b_mode_data_duration; >>> + __le32 tx_frame_cnt; >>> + __le32 mac_clk_mhz; >>> + >>> } __packed; >>> >>> >>> >>> Thanks, >>> Ben >>> > -- Ben Greear Candela Technologies Inc http://www.candelatech.com