From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D0A5C433FE for ; Wed, 3 Nov 2021 17:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6678F61101 for ; Wed, 3 Nov 2021 17:01:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233056AbhKCRD5 (ORCPT ); Wed, 3 Nov 2021 13:03:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233038AbhKCRDx (ORCPT ); Wed, 3 Nov 2021 13:03:53 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 520C4C061205 for ; Wed, 3 Nov 2021 10:01:17 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id k4so2889767plx.8 for ; Wed, 03 Nov 2021 10:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squareup.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DMBzmvBB22CaA8yfJuHBpGm7OJc6owoxQJi2DnYHmDQ=; b=Ygi8fQv59gfgwqZ8UAEbGTKMby89lkZW988rBOfZPoIbVnZrgIeKjxkyDSlq1HzhBN lH+tWlN7poas7qmmVToiuC9U/ghuwWOd7IGDHgh06BUEkmiRkZiF2Z3B6Lqe2RNRf+L2 DJrkKz3aQIPsCWgD8bpA7rMHAo6MX3cE4OTbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DMBzmvBB22CaA8yfJuHBpGm7OJc6owoxQJi2DnYHmDQ=; b=PfqOwqS+7MSScEGNkRE8pcOpZsclCK7auZwj0dZf5gqXvkp0pHlTsw8ODEQUNSa711 FaYsITURx/kzl/4O6cW7V8HuQV+X4C0B7rtkqQmxm6YoNgFwET3grN7KigHWfUVwugDk Eg/A1z+nLfeS7uYBwCvEOXi8xShiJ4EjZxvbd3IQilZ/0UEdAWXBy/TLi+joui3OOsWT n9+OyVFbd4F0cPG4CpyZDTpOesIhhrByHuk9VFUssJlekSyDYlYx2jYsEmqM9DX2xP7P p8+ZBk+Ch5hXbbBl5XFc3z/NBEJ1zGiUnPoQy2Ml4A40HKV9ZVdHNfGEMSUvc3A73E0M R3+Q== X-Gm-Message-State: AOAM533H5ncuVWcyogcHxsroLWchq1zuEyH2pCMp5D7j1iW3NjJuoaRG znntdqy8Bi+s5uekFXDJ1Oa3rf/XAR8jZw== X-Google-Smtp-Source: ABdhPJwFWw4jYft9LGXVGSTlOQj3Q3VNW9elUyrIOaU7e8FcQ0hcRQ2cZmJ6zFkP5jNPOpEJqcpSEg== X-Received: by 2002:a17:902:6bc5:b0:13f:f585:4087 with SMTP id m5-20020a1709026bc500b0013ff5854087mr39922356plt.32.1635958876669; Wed, 03 Nov 2021 10:01:16 -0700 (PDT) Received: from benl-m5lvdt.local ([2600:6c50:4d00:d401:d8a:3314:9c20:7eff]) by smtp.gmail.com with ESMTPSA id p17sm233807pgj.93.2021.11.03.10.01.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Nov 2021 10:01:16 -0700 (PDT) Subject: Re: [PATCH v2 2/2] wcn36xx: fix RX BD rate mapping for 5GHz legacy rates To: Loic Poulain Cc: Kalle Valo , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, "David S. Miller" , Jakub Kicinski , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211103155543.1037604-1-benl@squareup.com> <20211103155543.1037604-3-benl@squareup.com> From: Benjamin Li Message-ID: <5a74137a-97ee-711d-97a2-105b0dd92cee@squareup.com> Date: Wed, 3 Nov 2021 10:01:13 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 11/3/21 10:08 AM, Loic Poulain wrote: > Hi Ben, > > It looks fine, but can you replace it with a 'status.rate_idx >= 4'. > I get sporadic 5Ghz frames reported with rate_idx=0 (firmware miss?), > leading to warnings because status.rate_idx is -4(unsigned) in that > case. So better to report a wrong rate than a corrupted one. > Thanks for confirming that. Will send v3 that just falls-through on rate_idx < 4, no warn or log. Ben > > > Regards, > Loic >