From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73FDFC3A5A0 for ; Mon, 19 Aug 2019 20:09:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DBC5206C1 for ; Mon, 19 Aug 2019 20:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728123AbfHSUJR (ORCPT ); Mon, 19 Aug 2019 16:09:17 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:47280 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727925AbfHSUJR (ORCPT ); Mon, 19 Aug 2019 16:09:17 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hznxr-0003oD-Gz; Mon, 19 Aug 2019 22:09:15 +0200 Message-ID: <5bc077f7b2f017da7c027edd27a543910dd6ac32.camel@sipsolutions.net> Subject: Re: [PATCH] iwlwifi: Extended Key ID support for mvm and dvm From: Johannes Berg To: Alexander Wetzel , luciano.coelho@intel.com Cc: linux-wireless@vger.kernel.org, linuxwifi@intel.com Date: Mon, 19 Aug 2019 22:09:14 +0200 In-Reply-To: <52914e64663283eeff9445b8b1fb37986c15223d.camel@sipsolutions.net> (sfid-20190819_220332_573678_41D0461A) References: <20190819180540.2855-1-alexander@wetzel-home.de> <204c346ab9fc71865e4cb5f5c29ec33ca05050e2.camel@sipsolutions.net> <52914e64663283eeff9445b8b1fb37986c15223d.camel@sipsolutions.net> (sfid-20190819_220332_573678_41D0461A) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2019-08-19 at 22:03 +0200, Johannes Berg wrote: > > > While less desirable we still could get that working: The mvm driver > > would have to detect the key borders and then tell the firmware to > > switch over to the other key. But we would have to make sure to not > > re-enable A-MPDU aggregation till the card really has switched. > So probably you're right, and we'd have to disable A-MPDUs until we have > no outstanding old-key-retransmits, but that seems manageable. Actually, we probably have to even delay the key switch until there are no more frames to retransmit, because the hardware is involved to some extent and it won't know about two keys or something... Not really sure how it all works though, off the top of my head. johannes