linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Aloka Dixit <alokad@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5 2/2] mac80211: Add FILS discovery support
Date: Thu, 27 Aug 2020 11:48:06 +0200	[thread overview]
Message-ID: <5ca724421a6a9d8be3402e10dbd62a19b910b03a.camel@sipsolutions.net> (raw)
In-Reply-To: <20200805011838.28166-3-alokad@codeaurora.org>


> + *  @IEEE80211_HW_SUPPORTS_FILS_DISCOVERY: Hardware/driver supports FILS
> + *	discovery frame transmission


nit: extra space before the @

but in any case you really ought to just remove this, the driver can set
up whatever method you decide to use in cfg80211 (e.g. extended feature
flag) - no need for mac80211 to have extra code just to pass it through.

The flags here are intended for things that only mac80211 cares about.

johannes



      reply	other threads:[~2020-08-27  9:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05  1:18 [PATCH v5 0/2] Add FILS discovery support Aloka Dixit
2020-08-05  1:18 ` [PATCH v5 1/2] nl80211: " Aloka Dixit
2020-08-27  9:47   ` Johannes Berg
2020-08-05  1:18 ` [PATCH v5 2/2] mac80211: " Aloka Dixit
2020-08-27  9:48   ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ca724421a6a9d8be3402e10dbd62a19b910b03a.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=alokad@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).