From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4700C432C0 for ; Mon, 2 Dec 2019 10:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABD212070B for ; Mon, 2 Dec 2019 10:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727555AbfLBKa0 (ORCPT ); Mon, 2 Dec 2019 05:30:26 -0500 Received: from mail2.sp2max.com.br ([138.185.4.9]:37412 "EHLO mail2.sp2max.com.br" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727326AbfLBKa0 (ORCPT ); Mon, 2 Dec 2019 05:30:26 -0500 Received: from [172.17.0.170] (unknown [190.246.35.95]) (Authenticated sender: pablo@fliagreco.com.ar) by mail2.sp2max.com.br (Postfix) with ESMTPSA id E837F7B0877; Mon, 2 Dec 2019 07:30:17 -0300 (-03) Subject: Re: [PATCH v1] mt76: mt7615: Fix build with older compilers To: Sergei Shtylyov Cc: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Roy Luo , Kalle Valo , "David S. Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20191201181716.61892-1-pgreco@centosproject.org> From: =?UTF-8?Q?Pablo_Sebasti=c3=a1n_Greco?= Message-ID: <5e12af27-be82-894a-1abd-25d1f33a5144@centosproject.org> Date: Mon, 2 Dec 2019 07:30:15 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-SP2Max-MailScanner-Information: Please contact the ISP for more information X-SP2Max-MailScanner-ID: E837F7B0877.A307D X-SP2Max-MailScanner: Sem Virus encontrado X-SP2Max-MailScanner-SpamCheck: nao spam, SpamAssassin (not cached, escore=-2.9, requerido 6, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90) X-SP2Max-MailScanner-From: pgreco@centosproject.org Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2/12/19 06:18, Sergei Shtylyov wrote: > Hello! > > On 01.12.2019 21:17, Pablo Greco wrote: > >> Some compilers (tested with 4.8.5 from CentOS 7) fail properly process > >    Fail to? Right > >> FIELD_GET inside an inline function, which ends up in a BUILD_BUG_ON. >> Convert inline function to a macro. >> >> Fixes commit bf92e7685100 ("mt76: mt7615: add support for per-chain >> signal strength reporting") > >    Should be: > > Fixes: bf92e7685100 ("mt76: mt7615: add support for per-chain signal > strength reporting") > >    Do not ever break up the Fixes: line and don't insert empty lines > between it and other tags. Ack, I'll fix those for v2 > >> Reported in https://lkml.org/lkml/2019/9/21/146 >> >> Reported-by: kbuild test robot >> Signed-off-by: Pablo Greco > [...] > > MBR, Sergei Thanks, Pablo