From: YueHaibing <yuehaibing@huawei.com>
To: Joe Perches <joe@perches.com>, <johannes.berg@intel.com>,
<emmanuel.grumbach@intel.com>, <luciano.coelho@intel.com>,
<linuxwifi@intel.com>, <kvalo@codeaurora.org>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: Use kmemdup instead of duplicating its function
Date: Mon, 28 Jan 2019 13:58:43 +0800 [thread overview]
Message-ID: <5e72a592-b795-0d88-e393-fff65126ca47@huawei.com> (raw)
In-Reply-To: <0c2c9ef717676371950942b08556d0e0196559de.camel@perches.com>
On 2019/1/27 5:24, Joe Perches wrote:
> On Sat, 2019-01-26 at 20:42 +0800, YueHaibing wrote:
>> Use kmemdup rather than duplicating its implementation
> []
>> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
> []
>> @@ -1196,13 +1196,9 @@ iwl_parse_nvm_mcc_info(struct device *dev, const struct iwl_cfg *cfg,
>> regd_to_copy = sizeof(struct ieee80211_regdomain) +
>> valid_rules * sizeof(struct ieee80211_reg_rule);
>> - copy_rd = kzalloc(regd_to_copy, GFP_KERNEL);
>> - if (!copy_rd) {
>> + copy_rd = kmemdup(regd, regd_to_copy, GFP_KERNEL);
>
> This should probably be
>
> copy_rd = kmemdup(regd, struct_size(regd, reg_rules, valid_rules),
> GFP_KERNEL);
>
Yes, So also can remove 'regd_to_copy', I will do it in a new patch
Thanks!
>> + if (!copy_rd)
>> copy_rd = ERR_PTR(-ENOMEM);
>> - goto out;
>> - }
>> -
>> - memcpy(copy_rd, regd, regd_to_copy);
>>
>> out:
>> kfree(regdb_ptrs);
>
>
> .
>
prev parent reply other threads:[~2019-01-28 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 12:42 [PATCH] iwlwifi: Use kmemdup instead of duplicating its function YueHaibing
2019-01-26 21:24 ` Joe Perches
2019-01-28 5:58 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e72a592-b795-0d88-e393-fff65126ca47@huawei.com \
--to=yuehaibing@huawei.com \
--cc=emmanuel.grumbach@intel.com \
--cc=joe@perches.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).