Linux-Wireless Archive on lore.kernel.org
 help / Atom feed
* [PATCH v4] staging: wilc1000: fix registration frame size
@ 2019-01-07 14:43 Július Milan
  2019-01-08  2:52 ` Ajay.Kathat
  0 siblings, 1 reply; 2+ messages in thread
From: Július Milan @ 2019-01-07 14:43 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, linux-wireless, gregkh, Adham.Abozaeid, Ajay.Kathat

Fixes the following sparse warnings:

drivers/staging/wilc1000/host_interface.c:2360:30: warning:
 incorrect type in assignment (different base types)
    expected restricted __le32 [addressable] [assigned] [usertype] frame_type
    got restricted __le16 [usertype] <noident>

Fixes: 147ccfd451024 ("staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context")
Signed-off-by: Július Milan <jmilan.dev@gmail.com>
---
 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

v3:
- nothing really changed since v1, v2, I just messed emails and then patch
  format, sorry for that, it's my first patch :)

v4:
- changed struct wilc_reg_frame member frame_type type to le16
- reverted cast of frame_type to le32 in wilc_frame_register
- changed subject line, previous version has subject:
  "[PATCH v3] staging: wilc1000: fix cast to restricted __le32"
  https://www.spinics.net/lists/linux-wireless/msg181166.html

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 70c854d939ce..7acb790d850b 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -36,7 +36,7 @@ struct wilc_op_mode {
 struct wilc_reg_frame {
 	bool reg;
 	u8 reg_id;
-	__le32 frame_type;
+	__le16 frame_type;
 } __packed;
 
 struct wilc_drv_handler {
-- 
2.14.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v4] staging: wilc1000: fix registration frame size
  2019-01-07 14:43 [PATCH v4] staging: wilc1000: fix registration frame size Július Milan
@ 2019-01-08  2:52 ` Ajay.Kathat
  0 siblings, 0 replies; 2+ messages in thread
From: Ajay.Kathat @ 2019-01-08  2:52 UTC (permalink / raw)
  To: jmilan.dev, linux-kernel; +Cc: devel, linux-wireless, gregkh, Adham.Abozaeid



On 1/7/2019 8:13 PM, Július Milan wrote:
> Fixes the following sparse warnings:
> 
> drivers/staging/wilc1000/host_interface.c:2360:30: warning:
>  incorrect type in assignment (different base types)
>     expected restricted __le32 [addressable] [assigned] [usertype] frame_type
>     got restricted __le16 [usertype] <noident>
> 
> Fixes: 147ccfd451024 ("staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context")
> Signed-off-by: Július Milan <jmilan.dev@gmail.com>

Thanks, the change looks fine to me.

Reviewed-by: Ajay Singh <ajay.kathat@microchip.com>

Regards,
Ajay

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-07 14:43 [PATCH v4] staging: wilc1000: fix registration frame size Július Milan
2019-01-08  2:52 ` Ajay.Kathat

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox