From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6875C76186 for ; Wed, 24 Jul 2019 01:32:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 974612253D for ; Wed, 24 Jul 2019 01:32:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728280AbfGXBc3 (ORCPT ); Tue, 23 Jul 2019 21:32:29 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2743 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725837AbfGXBc2 (ORCPT ); Tue, 23 Jul 2019 21:32:28 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id BFCB5AEEA5EBA150532A; Wed, 24 Jul 2019 09:32:26 +0800 (CST) Received: from [127.0.0.1] (10.177.96.96) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 24 Jul 2019 09:32:24 +0800 Subject: Re: [net-next] mwifiex: use eth_broadcast_addr() to assign broadcast address To: , , , , References: <20190710072524.65953-1-maowenan@huawei.com> CC: , From: maowenan Message-ID: <609fa4ae-7210-7758-c8ff-1b06492356e1@huawei.com> Date: Wed, 24 Jul 2019 09:32:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190710072524.65953-1-maowenan@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.96.96] X-CFilter-Loop: Reflected Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org gentle ping... On 2019/7/10 15:25, Mao Wenan wrote: > This patch is to use eth_broadcast_addr() to assign broadcast address > insetad of memcpy(). > > Signed-off-by: Mao Wenan > --- > drivers/net/wireless/marvell/mwifiex/tdls.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/tdls.c b/drivers/net/wireless/marvell/mwifiex/tdls.c > index 18e654d..0931304 100644 > --- a/drivers/net/wireless/marvell/mwifiex/tdls.c > +++ b/drivers/net/wireless/marvell/mwifiex/tdls.c > @@ -731,7 +731,6 @@ mwifiex_construct_tdls_action_frame(struct mwifiex_private *priv, > u16 status_code, struct sk_buff *skb) > { > struct ieee80211_mgmt *mgmt; > - u8 bc_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; > int ret; > u16 capab; > struct ieee80211_ht_cap *ht_cap; > @@ -765,7 +764,7 @@ mwifiex_construct_tdls_action_frame(struct mwifiex_private *priv, > memmove(pos + ETH_ALEN, &mgmt->u.action.category, > sizeof(mgmt->u.action.u.tdls_discover_resp)); > /* init address 4 */ > - memcpy(pos, bc_addr, ETH_ALEN); > + eth_broadcast_addr(pos); > > ret = mwifiex_tdls_append_rates_ie(priv, skb); > if (ret) { >