From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A83DAC433E0 for ; Tue, 23 Mar 2021 07:46:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 592DB61998 for ; Tue, 23 Mar 2021 07:46:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbhCWHqV (ORCPT ); Tue, 23 Mar 2021 03:46:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbhCWHqO (ORCPT ); Tue, 23 Mar 2021 03:46:14 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8A79C061574; Tue, 23 Mar 2021 00:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=O18FJ1N2ZnMBsuKWvbeujuurm5C2kQ1VBxSCMJvGcZY=; b=cWPKqUjpsMjCIpmkK6qCc5RlZ9 BUO/fZSsBt5FneHlsDo3pLwn/HMORTIIWKHOnhzQP9rJU1dAqvzO/oX7owDaZDbGlu8APesldHFlg 6daNHdlLmQufWP8Vcj8XAbgpdQhQ/ckKqplvta8DeHh+9uO8vCb15iGT2dwsu2VYSDK4=; Received: from p4ff13c8d.dip0.t-ipconnect.de ([79.241.60.141] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1lObjl-0002Ce-18; Tue, 23 Mar 2021 08:46:01 +0100 Subject: Re: [RFC 2/7] ath10k: Add support to process rx packet in thread To: Ben Greear , Brian Norris Cc: Johannes Berg , Rajkumar Manoharan , Rakesh Pillai , ath10k , linux-wireless , Linux Kernel , Kalle Valo , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Doug Anderson , Evan Green References: <1595351666-28193-1-git-send-email-pillair@codeaurora.org> <1595351666-28193-3-git-send-email-pillair@codeaurora.org> <13573549c277b34d4c87c471ff1a7060@codeaurora.org> <04d7301d5ad7555a0377c7df530ad8522fc00f77.camel@sipsolutions.net> <1f2726ff-8ba9-5278-0ec6-b80be475ea98@nbd.name> <06a4f84b-a0d4-3f90-40bb-f02f365460ec@candelatech.com> <47d8be60-14ce-0223-bdf3-c34dc2451945@candelatech.com> From: Felix Fietkau Message-ID: <633feaed-7f34-15d3-1899-81eb1d6ae14f@nbd.name> Date: Tue, 23 Mar 2021 08:45:59 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <47d8be60-14ce-0223-bdf3-c34dc2451945@candelatech.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-03-23 04:01, Ben Greear wrote: > On 3/22/21 6:20 PM, Brian Norris wrote: >> On Mon, Mar 22, 2021 at 4:58 PM Ben Greear wrote: >>> On 7/22/20 6:00 AM, Felix Fietkau wrote: >>>> On 2020-07-22 14:55, Johannes Berg wrote: >>>>> On Wed, 2020-07-22 at 14:27 +0200, Felix Fietkau wrote: >>>>> >>>>>> I'm considering testing a different approach (with mt76 initially): >>>>>> - Add a mac80211 rx function that puts processed skbs into a list >>>>>> instead of handing them to the network stack directly. >>>>> >>>>> Would this be *after* all the mac80211 processing, i.e. in place of the >>>>> rx-up-to-stack? >>>> Yes, it would run all the rx handlers normally and then put the >>>> resulting skbs into a list instead of calling netif_receive_skb or >>>> napi_gro_frags. >>> >>> Whatever came of this? I realized I'm running Felix's patch since his mt76 >>> driver needs it. Any chance it will go upstream? >> >> If you're asking about $subject (moving NAPI/RX to a thread), this >> landed upstream recently: >> http://git.kernel.org/linus/adbb4fb028452b1b0488a1a7b66ab856cdf20715 >> >> It needs a bit of coaxing to work on a WiFi driver (including: WiFi >> drivers tend to have a different netdev for NAPI than they expose to >> /sys/class/net/), but it's there. >> >> I'm not sure if people had something else in mind in the stuff you're >> quoting though. > > No, I got it confused with something Felix did: > > https://github.com/greearb/mt76/blob/master/patches/0001-net-add-support-for-threaded-NAPI-polling.patch > > Maybe the NAPI/RX to a thread thing superceded Felix's patch? Yes, it did and it's in linux-next already. I sent the following change to make mt76 use it: https://github.com/nbd168/wireless/commit/1d4ff31437e5aaa999bd7a - Felix