From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>, Steve deRosier <derosier@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: ath6kl: assure headroom of skbuff is writable in .start_xmit()
Date: Wed, 26 Apr 2017 11:00:36 +0200 [thread overview]
Message-ID: <634a239c-a7fe-05ad-7429-2ac4915c185d@broadcom.com> (raw)
In-Reply-To: <20170426085337.293296148E@smtp.codeaurora.org>
On 4/26/2017 10:53 AM, Kalle Valo wrote:
> Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
>> An issue was found brcmfmac driver in which a skbuff in .start_xmit()
>> callback was actually cloned. So instead of checking for sufficient
>> headroom it should also be writable. Hence use skb_cow_head() to
>> check and expand the headroom appropriately.
>>
>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>
> Steve, would you have time to run a quick test with this?
>
> Patch set to Deferred.
Just a hint. I tested the equivalent patch in brcmfmac by doing a
skb_clone() just before the headroom if-statement (and a kfree_skb()
afterwards obviously ;-) ).
Regards,
Arend
next prev parent reply other threads:[~2017-04-26 9:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 9:10 [PATCH] ath6kl: assure headroom of skbuff is writable in .start_xmit() Arend van Spriel
2017-04-25 9:36 ` James Hughes
2017-04-25 11:10 ` Arend Van Spriel
2017-04-25 11:50 ` James Hughes
2017-04-26 8:53 ` Kalle Valo
2017-04-26 15:44 ` Steve deRosier
2017-04-26 18:03 ` Arend Van Spriel
2017-04-26 19:54 ` James Hughes
2017-04-27 4:55 ` Steve deRosier
2017-04-27 8:54 ` James Hughes
2017-05-04 13:08 ` Kalle Valo
[not found] ` <20170426085337.293296148E@smtp.codeaurora.org>
2017-04-26 9:00 ` Arend van Spriel [this message]
2017-05-19 7:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=634a239c-a7fe-05ad-7429-2ac4915c185d@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=derosier@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).