From: Larry Finger <Larry.Finger@lwfinger.net>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Rui Salvaterra <rsalvaterra@gmail.com>,
Stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] b43_legacy: Fix connection problem with WPA3
Date: Wed, 27 May 2020 09:57:06 -0500 [thread overview]
Message-ID: <6375413e-88b2-effa-c972-63eb65a36d09@lwfinger.net> (raw)
In-Reply-To: <87a71tv9g6.fsf@codeaurora.org>
On 5/27/20 7:39 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
>
>> Since the driver was first introduced into the kernel, it has only
>> handled the ciphers associated with WEP, WPA, and WPA2. It fails with
>> WPA3 even though mac80211 can handle those additional ciphers in software,
>> b43legacy did not report that it could handle them. By setting MFP_CAPABLE using
>> ieee80211_set_hw(), the problem is fixed.
>>
>> With this change, b43legacy will handle the ciohers it knows in hardare,
>> and let mac80211 handle the others in software. It is not necessary to
>> use the module parameter NOHWCRYPT to turn hardware encryption off.
>> Although this change essentially eliminates that module parameter,
>> I am choosing to keep it for cases where the hardware is broken,
>> and software encryption is required for all ciphers.
>>
>> This patch fixes a problem that has been in b43legacy since commit
>> 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx
>> devices").
>>
>> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: Stable <stable@vger.kernel.org>
>
> I'll do the same changes here as in patch 1.
>
Yes, both are OK.
Larry
next prev parent reply other threads:[~2020-05-27 14:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 15:59 [PATCH 0/2] Fix WPA3 problems with b43 and b43_legacy Larry Finger
2020-05-26 15:59 ` [PATCH 1/2] b43: Fix connection problem with WPA3 Larry Finger
2020-05-27 12:38 ` Kalle Valo
2020-05-27 16:58 ` Sasha Levin
2020-05-29 17:14 ` Kalle Valo
2020-05-26 15:59 ` [PATCH 2/2] b43_legacy: " Larry Finger
2020-05-27 12:39 ` Kalle Valo
2020-05-27 14:57 ` Larry Finger [this message]
2020-05-27 16:57 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6375413e-88b2-effa-c972-63eb65a36d09@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).