From: Tony Chuang <yhchuang@realtek.com>
To: Brian Norris <briannorris@chromium.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] rtw88: don't treat NULL pointer as an array
Date: Mon, 24 Aug 2020 01:50:32 +0000 [thread overview]
Message-ID: <64d1446a178a48fc997c35b79b5cea23@realtek.com> (raw)
In-Reply-To: <20200821211716.1631556-1-briannorris@chromium.org>
>
> I'm not a standards expert, but this really looks to be undefined
> behavior, when chip->dig_cck may be NULL. (And, we're trying to do a
> NULL check a few lines down, because some chip variants will use NULL.)
>
> Fixes: fc637a860a82 ("rtw88: 8723d: Set IG register for CCK rate")
Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> drivers/net/wireless/realtek/rtw88/phy.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/phy.c
> b/drivers/net/wireless/realtek/rtw88/phy.c
> index 8d93f3159746..9687b376d221 100644
> --- a/drivers/net/wireless/realtek/rtw88/phy.c
> +++ b/drivers/net/wireless/realtek/rtw88/phy.c
> @@ -147,12 +147,13 @@ void rtw_phy_dig_write(struct rtw_dev *rtwdev, u8
> igi)
> {
> struct rtw_chip_info *chip = rtwdev->chip;
> struct rtw_hal *hal = &rtwdev->hal;
> - const struct rtw_hw_reg *dig_cck = &chip->dig_cck[0];
> u32 addr, mask;
> u8 path;
>
> - if (dig_cck)
> + if (chip->dig_cck) {
> + const struct rtw_hw_reg *dig_cck = &chip->dig_cck[0];
> rtw_write32_mask(rtwdev, dig_cck->addr, dig_cck->mask, igi >> 1);
> + }
>
> for (path = 0; path < hal->rf_path_num; path++) {
> addr = chip->dig[path].addr;
Thanks.
Yen-Hsuan
next prev parent reply other threads:[~2020-08-24 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 21:17 [PATCH] rtw88: don't treat NULL pointer as an array Brian Norris
2020-08-24 1:50 ` Tony Chuang [this message]
2020-08-27 10:04 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64d1446a178a48fc997c35b79b5cea23@realtek.com \
--to=yhchuang@realtek.com \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).