linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>, "Kalle Valo" <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	brcm80211-dev-list@cypress.com,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] brcmfmac: support monitor frames with hardware/ucode header
Date: Fri, 25 Jan 2019 09:51:55 +0100	[thread overview]
Message-ID: <66fcd804-73f7-ae58-53f5-537ec8cb2802@broadcom.com> (raw)
In-Reply-To: <20190122110858.12993-1-zajec5@gmail.com>

On 1/22/2019 12:08 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> The new FullMAC firmwares for 4366b1/4366c0 were supposed to provide
> monitor frames with radiotap header but it doesn't seem to be the case.

I was not aware that this was supposed to. I did not build a radiotap 
variant to keep it feature-wise similar to 4366b0 firmware.

> Testing the latest release resulted in discovering a new format being
> used. It seems (almost?) identical to the one known from ucode used in
> SoftMAC devices which is most likely the same codebase anyway.

I am a bit confused. How many formats are there? It is either ucode 
format or radiotap, right?

> While radiotap support was meant to be announced with the "rtap" fw
> capability string it seems no alternative was added for the hw/ucode
> format. It means each firmware requires a feature mapping quirk.

I thought we only needed a quirk for the firmware that provide radiotap 
but do not announce it. For the others we can assume ucode format if 
monitor mode is supported. Probably missing something.

Regards,
Arend

  reply	other threads:[~2019-01-25  8:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 11:08 [PATCH] brcmfmac: support monitor frames with hardware/ucode header Rafał Miłecki
2019-01-25  8:51 ` Arend Van Spriel [this message]
2019-01-25  9:11   ` Rafał Miłecki
2019-01-25  9:32     ` Arend Van Spriel
2019-02-07 16:36 ` Kalle Valo
     [not found] ` <20190207163638.53A20607DF@smtp.codeaurora.org>
2019-02-08  6:41   ` Rafał Miłecki
2019-02-08  6:42 ` [PATCH V2] brcmfmac: support monitor frames with the " Rafał Miłecki
2019-02-08  8:17   ` Arend Van Spriel
2019-02-08 15:27   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66fcd804-73f7-ae58-53f5-537ec8cb2802@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).