From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F091C4338F for ; Fri, 13 Aug 2021 10:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20DBE610CD for ; Fri, 13 Aug 2021 10:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240231AbhHMKwf (ORCPT ); Fri, 13 Aug 2021 06:52:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240230AbhHMKwf (ORCPT ); Fri, 13 Aug 2021 06:52:35 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 941CFC061756 for ; Fri, 13 Aug 2021 03:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2nGS+ijdQIDpgRg9ZkkZPkHb1ACLUfXfWxSReLJkR2Y=; b=pKk47s/qxvtcQQNvNIM67fp5mX DHXUh9pmjzt//CGoguWjomRDnZbouGlECAri8nqGRnYMKyFn4BSug9xt4slWEjrGbHDbAgh1Ltl+u m2m+9pGeCtQE/KFaLM0qAF3I/BPI4vz/wCbWqY5xS72MklaSiax51Ojv8Skfg/ilRHaY=; Received: from p4ff13206.dip0.t-ipconnect.de ([79.241.50.6] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1mEUnC-0008Er-SC; Fri, 13 Aug 2021 12:52:02 +0200 Subject: Re: [PATCH] mt76: mt7915: add LED support To: MeiChia Chiu Cc: Lorenzo Bianconi , Shayne Chen , Evelyn Tsai , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, Ryder Lee , Money Wang References: <20210621141430.17577-1-MeiChia.Chiu@mediatek.com> From: Felix Fietkau Message-ID: <670252a9-636c-9d3d-5d6e-acfcabfff4c0@nbd.name> Date: Fri, 13 Aug 2021 12:52:02 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210621141430.17577-1-MeiChia.Chiu@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-06-21 16:14, MeiChia Chiu wrote: > From: MeiChia Chiu > > Initialize brightness_set and blink_set callbacks to enable LED support. > > Signed-off-by: MeiChia Chiu > Signed-off-by: Ryder Lee > Signed-off-by: Money Wang > --- > .../net/wireless/mediatek/mt76/mt7915/init.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++ > .../net/wireless/mediatek/mt76/mt7915/mmio.c | 6 +++-- > .../net/wireless/mediatek/mt76/mt7915/regs.h | 19 ++++++++++++++ > 3 files changed, 92 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c > index e027273..defb0ec 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c > @@ -151,6 +151,64 @@ static int mt7915_thermal_init(struct mt7915_phy *phy) > return 0; > } > > +static void mt7915_led_set_config(struct led_classdev *led_cdev, > + u8 delay_on, u8 delay_off) > +{ > + struct mt7915_dev *dev; > + struct mt76_dev *mt76; > + u32 val; > + > + mt76 = container_of(led_cdev, struct mt76_dev, led_cdev); > + dev = container_of(mt76, struct mt7915_dev, mt76); > + > + /* select TX blink mode, 2: only data frames */ > + mt76_rmw_field(dev, MT_TMAC_TCR0(0), MT_TMAC_TCR0_TX_BLINK, 2); Does that mean the hw triggers the LED with the configured on/off delay on TX? I think blinking should be controlled entirely by software. - Felix