Re: [PATCH RESEND] b43: implement baseband init for LP-PHY <= rev1

From: "Gábor Stefanik" <netrolller.3d@gmail.com>
To: Michael Buesch <mb@bu3sch.de>, Larry Finger <Larry.Finger@lwfinger.net>
Cc: bcm43xx-dev@lists.berlios.de,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH RESEND] b43: implement baseband init for LP-PHY <= rev1
Date: Mon, 3 Aug 2009 23:34:09 +0200	[thread overview]
Message-ID: <69e28c910908031434q53fd7d6jb346f49927a634a7@mail.gmail.com> (raw)
In-Reply-To: <200908032316.30237.mb@bu3sch.de>

On Mon, Aug 3, 2009 at 11:16 PM, Michael Buesch<mb@bu3sch.de> wrote:
> On Monday 03 August 2009 22:58:30 Larry Finger wrote:
>> Gábor states it the way the Broadcom routine is written. They have the
>> flags divided into 3 16-bit values - high, middle, and low. The values
>> are kept in arrays - one set is for the current band and the other is
>> for both bands. When the routine is entered, the appropriate quantity
>> is saved in a temporary, then the array value is maskset. Only when
>> the resulting value changes is the shared memory location updated. The
>> implication is that shared memory writes are expensive. Is that true?
>
> No. I think it has other reasons.
>
> --
> Greetings, Michael.
>

In that case, is the code correct:

-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)