From: "Gábor Stefanik" <netrolller.3d@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>, Mark Huijgen <mark@huijgen.tk>,
Broadcom Wireless <bcm43xx-dev@lists.berlios.de>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] b43: Add LP-PHY firmware loading support
Date: Fri, 14 Aug 2009 15:02:35 +0200 [thread overview]
Message-ID: <69e28c910908140602x3873f30bt95b5c148305a5e1e@mail.gmail.com> (raw)
In-Reply-To: <4A855FEA.7030907@lwfinger.net>
2009/8/14 Larry Finger <Larry.Finger@lwfinger.net>:
> Gábor Stefanik wrote:
>> Add support for loading LP-PHY firmware to b43_try_request_fw.
>>
>> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
>> ---
>> For anyone hoping that the channel switch patches will make their LP
>> card work - this is also definitely required.
>>
>> Mark, this doesn't fix your problem specifically, but it will be needed
>> after your problem is fixed.
>>
>> drivers/net/wireless/b43/main.c | 24 +++++++++++++++++++++++-
>> 1 files changed, 23 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/main.c
>> b/drivers/net/wireless/b43/main.c
>> index fbcbe4f..1e657fe 100644
>> --- a/drivers/net/wireless/b43/main.c
>> +++ b/drivers/net/wireless/b43/main.c
>> @@ -2062,8 +2062,12 @@ static int b43_try_request_fw(struct
>> b43_request_fw_context *ctx)
>> filename = "ucode5";
>> else if ((rev >= 11) && (rev <= 12))
>> filename = "ucode11";
>> - else if (rev >= 13)
>> + else if (rev == 13)
>> filename = "ucode13";
>> + else if (rev == 14)
>> + filename = "ucode14";
>> + else if (rev >= 15)
>> + filename = "ucode15";
>
> As shown by http://bcm-v4.sipsolutions.net/802.11/Init/Firmware, one
> should also have "ucode16".
>
>> else
>> goto err_no_ucode;
>> err = b43_do_request_fw(ctx, filename, &fw->ucode);
>> @@ -2111,6 +2115,15 @@ static int b43_try_request_fw(struct
>> b43_request_fw_context *ctx)
>> else
>> goto err_no_initvals;
>> break;
>> + case B43_PHYTYPE_LP:
>> + if (rev == 13)
>> + filename = "lp0initvals13";
>> + else if (rev == 14)
>> + filename = "lp0initvals14";
>> + else if (rev >= 15)
>> + filename = "lp0initvals15";
>> + else
>
> Same for lp0initvals16.
>
>> + goto err_no_initvals;
>> default:
>> goto err_no_initvals;
>> }
>> @@ -2145,6 +2158,15 @@ static int b43_try_request_fw(struct
>> b43_request_fw_context *ctx)
>> else
>> goto err_no_initvals;
>> break;
>> + case B43_PHYTYPE_LP:
>> + if (rev == 13)
>> + filename = "lp0bsinitvals13";
>> + else if (rev == 14)
>> + filename = "lp0bsinitvals14";
>> + else if (rev >= 15)
>> + filename = "lp0bsinitvals15";
>
> and lp0bsinitvals16.
>
>> + else
>> + goto err_no_initvals;
>> default:
>> goto err_no_initvals;
>> }
>
> Larry
>
Is rev.16 firmware available anywhere?
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
next prev parent reply other threads:[~2009-08-14 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 11:51 [PATCH] b43: Add LP-PHY firmware loading support Gábor Stefanik
2009-08-14 12:11 ` Mark Huijgen
2009-08-14 13:00 ` Larry Finger
2009-08-14 13:02 ` Gábor Stefanik [this message]
2009-08-14 13:10 ` Larry Finger
[not found] ` <69e28c910908140623r6f158a89pcf145bad7b244af8@mail.gmail.com>
[not found] ` <4A85678E.6080205@lwfinger.net>
2009-08-14 15:26 ` Gábor Stefanik
2009-08-14 20:17 ` Michael Buesch
2009-08-14 20:20 ` Gábor Stefanik
2009-08-14 20:41 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69e28c910908140602x3873f30bt95b5c148305a5e1e@mail.gmail.com \
--to=netrolller.3d@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mark@huijgen.tk \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).