linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <jes.sorensen@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang
Date: Sat, 17 Apr 2021 14:30:46 -0400	[thread overview]
Message-ID: <6bcce753-ceca-8731-ec66-6f467a3199fd@gmail.com> (raw)
In-Reply-To: <20210417175201.2D5A7C433F1@smtp.codeaurora.org>

On 4/17/21 1:52 PM, Kalle Valo wrote:
> "Gustavo A. R. Silva" <gustavoars@kernel.org> wrote:
> 
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix
>> multiple warnings by replacing /* fall through */ comments with
>> the new pseudo-keyword macro fallthrough; instead of letting the
>> code fall through to the next case.
>>
>> Notice that Clang doesn't recognize /* fall through */ comments as
>> implicit fall-through markings.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> 
> Patch applied to wireless-drivers-next.git, thanks.
> 
> bf3365a856a1 rtl8xxxu: Fix fall-through warnings for Clang
> 

Sorry this junk patch should not have been applied.

Jes

  parent reply	other threads:[~2021-04-17 18:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05  9:48 [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-05 13:40 ` Kalle Valo
2021-03-05 16:49   ` Gustavo A. R. Silva
2021-03-10 19:14   ` Kees Cook
2021-03-10 19:31     ` Jes Sorensen
2021-03-10 19:45       ` Kees Cook
2021-03-10 19:51         ` Jes Sorensen
2021-03-10 20:59           ` Kees Cook
2021-04-17 18:29             ` Jes Sorensen
2021-04-17 19:24               ` Gustavo A. R. Silva
2021-04-19 11:58                 ` Jes Sorensen
2021-03-11  7:00     ` Kalle Valo
2021-03-11  7:16       ` Gustavo A. R. Silva
2021-04-17 17:52 ` Kalle Valo
     [not found] ` <20210417175201.2D5A7C433F1@smtp.codeaurora.org>
2021-04-17 18:30   ` Jes Sorensen [this message]
2021-04-18  0:09     ` Joe Perches
2021-04-19 11:56       ` Jes Sorensen
     [not found] ` <20210417175201.280F9C4338A@smtp.codeaurora.org>
2021-04-19 22:58   ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bcce753-ceca-8731-ec66-6f467a3199fd@gmail.com \
    --to=jes.sorensen@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gustavoars@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).