From: Jan Kiszka <jan.kiszka@web.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Wei Xu <xuwei5@hisilicon.com>
Cc: Ryan Grachek <ryan@edited.us>,
John Stultz <john.stultz@linaro.org>,
linux-wireless@vger.kernel.org, "Reizer, Eyal" <eyalr@ti.com>,
Valentin Schneider <valentin.schneider@arm.com>
Subject: [PATCH] arm64: dts: hikey: Give wifi some time after power-on
Date: Sun, 30 Dec 2018 12:38:11 +0100 [thread overview]
Message-ID: <6ccac7db-3ab7-e396-90be-8681a8ee336b@web.de> (raw)
From: Jan Kiszka <jan.kiszka@siemens.com>
Somewhere along recent changes to power control of the wl1835, power-on
became very unreliable on the hikey, failing like this:
wl1271_sdio: probe of mmc2:0001:1 failed with error -16
wl1271_sdio: probe of mmc2:0001:2 failed with error -16
After playing with some dt parameters and comparing to other users of
this chip, it turned out we need some power-on delay to make things
stable again. In contrast to those other users which define 200 ms, the
hikey is already very happy with 1 ms.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Tested with 4.19 and linus/master.
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index f4964bee6a1a..1e771bf201b9 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -118,6 +118,7 @@
reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
clocks = <&pmic>;
clock-names = "ext_clock";
+ post-power-on-delay-ms = <1>;
power-off-delay-us = <10>;
};
--
2.16.4
next reply other threads:[~2018-12-30 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 11:38 Jan Kiszka [this message]
2019-01-02 22:21 ` [PATCH] arm64: dts: hikey: Give wifi some time after power-on John Stultz
2019-01-03 21:32 ` Ulf Hansson
2019-01-06 9:53 ` Jan Kiszka
2019-01-15 8:10 ` Jan Kiszka
2019-01-15 8:13 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ccac7db-3ab7-e396-90be-8681a8ee336b@web.de \
--to=jan.kiszka@web.de \
--cc=eyalr@ti.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ryan@edited.us \
--cc=valentin.schneider@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).