archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <>
To: Brian Norris <>
Cc: Youghandhar Chintala <>,,,,,,,,,,,
Subject: Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery
Date: Thu, 17 Dec 2020 14:57:24 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <X9vaqxub2F/>

On 12/17/20 2:24 PM, Brian Norris wrote:
> On Tue, Dec 15, 2020 at 10:23:33AM -0800, Ben Greear wrote:
>> On 12/15/20 9:21 AM, Youghandhar Chintala wrote:
>>> From: Rakesh Pillai <>
>>> Currently in case of target hardware restart ,we just reconfig and
>>> re-enable the security keys and enable the network queues to start
>>> data traffic back from where it was interrupted.
>> Are there any known mac80211 radios/drivers that *can* support seamless restarts?
>> If not, then just could always enable this feature in mac80211?
> I'm quite sure that iwlwifi intentionally supports a seamless restart.
>  From my experience with dealing with user reports, I don't recall any
> issues where restart didn't function as expected, unless there was some
> deeper underlying failure (e.g., hardware/power failure; driver bugs /
> lockups).
> I don't have very good stats for ath10k/QCA6174, but it survives
> our testing OK and I again don't recall any user-reported complaints in
> this area. I'd say this is a weaker example though, as I don't have as
> clear of data. (By contrast, ath10k/WCN399x, which Rakesh, et al, are
> patching here, does not pass our tests at all, and clearly fails to
> recover from "seamless" restarts, as noted in patch 3.)
> I'd also note that we don't operate in AP mode -- only STA -- and IIRC
> Ben, you've complained about AP mode in the past.

I complain about all sorts of things, but I'm usually running
station mode :)

Do you actually see iwlwifi stations stay associated through
firmware crashes?

Anyway, happy to hear some have seamless recovery, and in that case,
I have no objections to the patch.


Ben Greear <>
Candela Technologies Inc

  reply	other threads:[~2020-12-17 22:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 17:21 [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery Youghandhar Chintala
2020-12-15 18:23 ` Ben Greear
2020-12-16 11:35   ` Rakesh Pillai
2020-12-17 22:24   ` Brian Norris
2020-12-17 22:57     ` Ben Greear [this message]
2020-12-17 23:18       ` Brian Norris
2020-12-17 22:30 ` Brian Norris
2020-12-15 17:30 Youghandhar Chintala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).