linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Alexander Lobakin <alobakin@dlink.ru>,
	David Miller <davem@davemloft.net>
Cc: pabeni@redhat.com, ecree@solarflare.com,
	nicholas.johnson-opensource@outlook.com.au, jiri@mellanox.com,
	edumazet@google.com, idosch@mellanox.com, petrm@mellanox.com,
	sd@queasysnail.net, f.fainelli@gmail.com,
	jaswinder.singh@linaro.org, ilias.apalodimas@linaro.org,
	linux-kernel@vger.kernel.org, emmanuel.grumbach@intel.com,
	luciano.coelho@intel.com, linuxwifi@intel.com,
	kvalo@codeaurora.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()
Date: Wed, 27 Nov 2019 09:30:51 +0100	[thread overview]
Message-ID: <6da209ffe31744d79c1394e1f3d038db19beca51.camel@sipsolutions.net> (raw)
In-Reply-To: <4cb1abfb7cbd137151f024405f7b0678@dlink.ru>

On Wed, 2019-11-27 at 10:47 +0300, Alexander Lobakin wrote:

> > Can I get some kind of fix in the next 24 hours?  I want to send a 
> > quick
> > follow-on pull request to Linus to deal with all of the fallout, and in
> > particular fix this regression.
> 
> If Intel guys and others will agree, I'll send a patch which will add
> manual napi->rx_list flushing in iwlwifi driver in about ~2-3 hours.

Sounds fine to me.

> Anyway, this driver should get a proper NAPI in future releases to
> prevent problems like this one.

Yeah, we'll work on that, but that might take a bit longer :)

johannes


  reply	other threads:[~2019-11-27  8:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191014080033.12407-1-alobakin@dlink.ru>
     [not found] ` <20191015.181649.949805234862708186.davem@davemloft.net>
     [not found]   ` <7e68da00d7c129a8ce290229743beb3d@dlink.ru>
     [not found]     ` <PSXP216MB04388962C411CD0B17A86F47804A0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
     [not found]       ` <c762f5eee08a8f2d0d6cb927d7fa3848@dlink.ru>
2019-11-25  8:25         ` [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() Alexander Lobakin
2019-11-25  9:09           ` Nicholas Johnson
2019-11-25 10:31             ` Edward Cree
2019-11-25 10:58               ` Alexander Lobakin
2019-11-25 11:05                 ` Johannes Berg
2019-11-25 11:42                   ` Paolo Abeni
2019-11-25 12:02                     ` Alexander Lobakin
2019-11-25 13:21                       ` Edward Cree
2019-11-25 13:39                         ` Alexander Lobakin
2019-11-26 23:57                       ` David Miller
2019-11-27  7:47                         ` Alexander Lobakin
2019-11-27  8:30                           ` Johannes Berg [this message]
2019-11-27  9:47                         ` Alexander Lobakin
2019-11-25 12:11                     ` Kalle Valo
2019-11-25 13:07                     ` Nicholas Johnson
2019-11-25 13:11               ` Nicholas Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6da209ffe31744d79c1394e1f3d038db19beca51.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=alobakin@dlink.ru \
    --cc=davem@davemloft.net \
    --cc=ecree@solarflare.com \
    --cc=edumazet@google.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=jiri@mellanox.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=luciano.coelho@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicholas.johnson-opensource@outlook.com.au \
    --cc=pabeni@redhat.com \
    --cc=petrm@mellanox.com \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).