linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 00/18] mac80211/driver security fixes
Date: Mon, 17 May 2021 11:54:33 -0700	[thread overview]
Message-ID: <704e1c77-6c48-79f7-043a-b2d03fbfef8b@candelatech.com> (raw)
In-Reply-To: <20210511180259.159598-1-johannes@sipsolutions.net>

On 5/11/21 11:02 AM, Johannes Berg wrote:
> Several security issues in the 802.11 implementations were found by
> Mathy Vanhoef (New York University Abu Dhabi), who has published all
> the details at
> 
> 	https://papers.mathyvanhoef.com/usenix2021.pdf

Is anyone backporting this to 4.19 and other 'stable' kernels?

For anyone using ath10k-ct driver, I have initial update of the
driver done for 4.19 (owrt uses this), but cannot compile against
the 4.19 kernel unless the mac80211 changes are also backported.

In interest of not duplicating effort...I was hoping these would
just show up in the 4.19 stable sometime soon...

Thanks,
Ben

> 
> 
> Specifically, the following CVEs were assigned:
> 
>   * CVE-2020-24586 - Fragmentation cache not cleared on reconnection
>   * CVE-2020-24587 - Reassembling fragments encrypted under different
>                      keys
>   * CVE-2020-24588 - Accepting non-SPP A-MSDU frames, which leads to
>                      payload being parsed as an L2 frame under an
>                      A-MSDU bit toggling attack
>   * CVE-2020-26139 - Forwarding EAPOL from unauthenticated sender
>   * CVE-2020-26140 - Accepting plaintext data frames in protected
>                      networks
>   * CVE-2020-26141 - Not verifying TKIP MIC of fragmented frames
>   * CVE-2020-26142 - Processing fragmented frames as full frames
>   * CVE-2020-26143 - Accepting fragmented plaintext frames in
>                      protected networks
>   * CVE-2020-26144 - Always accepting unencrypted A-MSDU frames that
>                      start with RFC1042 header with EAPOL ethertype
>   * CVE-2020-26145 - Accepting plaintext broadcast fragments as full
>                      frames
>   * CVE-2020-26146 - Reassembling encrypted fragments with non-consecutive
>                      packet numbers
>   * CVE-2020-26147 - Reassembling mixed encrypted/plaintext fragments
> 
> 
> In general, the scope of these attacks is that they may allow an
> attacker to
>   * inject L2 frames that they can more or less control (depending on the
>     vulnerability and attack method) into an otherwise protected network;
>   * exfiltrate (some) network data under certain conditions, this is
>     specific to the fragmentation issues.
> 
> 
> A subset of these issues is known to apply to the Linux IEEE 802.11
> implementation (mac80211). Where it is affected, the attached patches
> fix the issues, even if not all of them reference the exact CVE IDs.
> 
> In addition, driver and/or firmware updates may be necessary, as well
> as potentially more fixes to mac80211, depending on how drivers are
> using it.
> 
> Specifically, for Intel devices, firmware needs to be updated to the
> most recently released versions (which was done without any reference
> to the security issues) to address some of the vulnerabilities.
> 
> To have a single set of patches, I'm also including patches for the
> ath10k and ath11k drivers here.
> 
> We currently don't have information about how other drivers are, if
> at all, affected.
> 
> johannes
> 
> 
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

      parent reply	other threads:[~2021-05-17 18:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 18:02 Johannes Berg
2021-05-11 18:02 ` [PATCH 01/18] mac80211: assure all fragments are encrypted Johannes Berg
2021-05-11 18:02 ` [PATCH 02/18] mac80211: prevent mixed key and fragment cache attacks Johannes Berg
2021-05-11 18:02 ` [PATCH 03/18] mac80211: properly handle A-MSDUs that start with an RFC 1042 header Johannes Berg
2021-05-11 18:02 ` [PATCH 04/18] cfg80211: mitigate A-MSDU aggregation attacks Johannes Berg
2021-05-11 18:02 ` [PATCH 05/18] mac80211: drop A-MSDUs on old ciphers Johannes Berg
2021-05-11 18:02 ` [PATCH 06/18] mac80211: add fragment cache to sta_info Johannes Berg
2021-05-11 18:02 ` [PATCH 07/18] mac80211: check defrag PN against current frame Johannes Berg
2021-05-11 18:02 ` [PATCH 08/18] mac80211: prevent attacks on TKIP/WEP as well Johannes Berg
2021-05-11 18:02 ` [PATCH 09/18] mac80211: do not accept/forward invalid EAPOL frames Johannes Berg
2021-05-11 18:02 ` [PATCH 10/18] mac80211: extend protection against mixed key and fragment cache attacks Johannes Berg
2021-05-11 18:02 ` [PATCH 11/18] ath10k: add CCMP PN replay protection for fragmented frames for PCIe Johannes Berg
2021-05-14 22:23   ` Abhishek Kumar
2021-05-11 18:02 ` [PATCH 12/18] ath10k: drop fragments with multicast DA " Johannes Berg
2021-05-11 18:02 ` [PATCH 13/18] ath10k: drop fragments with multicast DA for SDIO Johannes Berg
2021-05-11 18:02 ` [PATCH 14/18] ath10k: drop MPDU which has discard flag set by firmware " Johannes Berg
2021-05-12 18:35   ` Brian Norris
2021-05-13 17:18     ` Jeff Johnson
2021-05-11 18:02 ` [PATCH 15/18] ath10k: Fix TKIP Michael MIC verification for PCIe Johannes Berg
2021-05-11 18:02 ` [PATCH 16/18] ath10k: Validate first subframe of A-MSDU before processing the list Johannes Berg
2021-05-11 18:02 ` [PATCH 17/18] ath11k: Clear the fragment cache during key install Johannes Berg
2021-05-11 18:02 ` [PATCH 18/18] ath11k: Drop multicast fragments Johannes Berg
2021-05-17 18:54 ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=704e1c77-6c48-79f7-043a-b2d03fbfef8b@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --subject='Re: [PATCH 00/18] mac80211/driver security fixes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox