Re: [RFC] Introduce NL80211_IFTYPE_MLO_LINK_DEVICE for MLO link (IEEE 802.11be)

[Arend van Spriel <arend.vanspriel@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 2831 bytes --]

On 09-12-2020 16:36, Johannes Berg wrote:
> Hi,
> 
>> Multi-link support is introduced in 802.11be specification.
> [...]
> 
> I'll definitely have to take a closer look at this and the spec and
> think about it - but a couple of quick comments below.

Did not get my hands on the spec yet, but just firing random thoughts. 
This multi-link support sounds a bit like bonding. Could that be 
leveraged for wireless? I wonder why there is a need for a non-netdev 
interface. Does networking layer need to be aware of the multi-link for 
scheduling traffic to it? Is there one driver per multi-link or per radio?

[...]

>>   	struct sk_buff *msg;
>>   	void *hdr;
>> +	struct nlattr *nested, *nested_mlo_links;
>> +	struct cfg80211_mlo_link_device_params *mlo_link;
>> +	int i = 0;
>>   
>>   	msg = nlmsg_new(100 + cr->req_ie_len + cr->resp_ie_len +
>>   			cr->fils.kek_len + cr->fils.pmk_len +
>> -			(cr->fils.pmkid ? WLAN_PMKID_LEN : 0), gfp);
>> +			(cr->fils.pmkid ? WLAN_PMKID_LEN : 0) +
>> +			(cr->n_mlo_links ? cr->n_mlo_links * 32 : 0), gfp);
> 
> 32 probably should be some NLA_SIZE or something constant?

Probably sizeof(*mlo_link) ?

> There's also no point in the ternary operator since 0 * 32 is 0 :)
> 
>>   /* Consumes bss object one way or another */
>> @@ -833,7 +849,9 @@ void cfg80211_connect_done(struct net_device *dev,
>>   	ev = kzalloc(sizeof(*ev) + (params->bssid ? ETH_ALEN : 0) +
>>   		     params->req_ie_len + params->resp_ie_len +
>>   		     params->fils.kek_len + params->fils.pmk_len +
>> -		     (params->fils.pmkid ? WLAN_PMKID_LEN : 0), gfp);
>> +		     (params->fils.pmkid ? WLAN_PMKID_LEN : 0) +
>> +		     (params->n_mlo_links ? params->n_mlo_links *
>> +		      sizeof(struct cfg80211_mlo_link_device_params) : 0), gfp);
> 
> same here, no need for the ternary
> 
> 
> It feels strangely asymmetric to have stop and no start ... but I guess
> that's the part where I need to think about it and look a bit at how it
> all works :)

Had the same feeling in my gutt (wherever that is ;-)

Regards,
Arend

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4176 bytes --]