* [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()
@ 2017-07-19 15:37 Gabriel C
2017-07-19 16:26 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Gabriel C @ 2017-07-19 15:37 UTC (permalink / raw)
To: ath10k; +Cc: Ryan Hsu, linux-wireless, linux-kernel, netdev, Kalle Valo
Each time we get disconencted from AP we get flooded with messages like:
...
ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
<until ratelimit kicks in>
ath10k_warn: 155 callbacks suppressed
...
Use ath10k_dbg() here too.
Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 398dda978d6e..75d9b59b7e63 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
*/
if (!rx_status->freq) {
- ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
+ ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
return false;
}
--
2.13.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()
2017-07-19 15:37 [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg() Gabriel C
@ 2017-07-19 16:26 ` Joe Perches
2017-07-19 18:12 ` Gabriel C
2017-07-19 18:24 ` Gabriel Craciunescu
0 siblings, 2 replies; 7+ messages in thread
From: Joe Perches @ 2017-07-19 16:26 UTC (permalink / raw)
To: Gabriel C, ath10k
Cc: Ryan Hsu, linux-wireless, linux-kernel, netdev, Kalle Valo
On Wed, 2017-07-19 at 17:37 +0200, Gabriel C wrote:
> Each time we get disconencted from AP we get flooded with messages like:
>
> ...
> ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
> <until ratelimit kicks in>
> ath10k_warn: 155 callbacks suppressed
[]
> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
[]
> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
> */
>
> if (!rx_status->freq) {
> - ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
> + ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
> return false;
> }
Hi. This doesn't apply because of tab to space conversions.
Please use git send-email to send your patch.
Maybe read Documentation/process/email-clients.rst
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()
2017-07-19 16:26 ` Joe Perches
@ 2017-07-19 18:12 ` Gabriel C
2017-07-19 18:24 ` Gabriel Craciunescu
1 sibling, 0 replies; 7+ messages in thread
From: Gabriel C @ 2017-07-19 18:12 UTC (permalink / raw)
To: Joe Perches, ath10k
Cc: Ryan Hsu, linux-wireless, linux-kernel, netdev, Kalle Valo
On 19.07.2017 18:26, Joe Perches wrote:
> On Wed, 2017-07-19 at 17:37 +0200, Gabriel C wrote:
>> Each time we get disconencted from AP we get flooded with messages like:
>>
>> ...
>> ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
>> <until ratelimit kicks in>
>> ath10k_warn: 155 callbacks suppressed
>
> []
>
>> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
> []
>> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>> */
>>
>> if (!rx_status->freq) {
>> - ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
>> + ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
>> return false;
>> }
>
> Hi. This doesn't apply because of tab to space conversions.
>
> Please use git send-email to send your patch.
Yes you are right .. I think newer thunderbird just doesn't work anymore to send patches.
Will have a look to setup git send-email and resend.
>
> Maybe read Documentation/process/email-clients.rst
>
I use tbird to send patches forver but it seems latest updates here broke it some sort.
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()
2017-07-19 16:26 ` Joe Perches
2017-07-19 18:12 ` Gabriel C
@ 2017-07-19 18:24 ` Gabriel Craciunescu
2017-07-19 18:41 ` Ryan Hsu
1 sibling, 1 reply; 7+ messages in thread
From: Gabriel Craciunescu @ 2017-07-19 18:24 UTC (permalink / raw)
To: ath10k
Cc: ryanhsu, joe, kvalo, linux-wireless, linux-kernel, netdev,
Gabriel Craciunescu
From: Gabriel Craciunescu <nix.or.die@gmail.com>
Each time we get disconencted from AP we get flooded with messages like:
...
ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
<until ratelimit kicks in>
ath10k_warn: 155 callbacks suppressed
...
Use ath10k_dbg() here too.
Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 398dda978d6e..75d9b59b7e63 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
*/
if (!rx_status->freq) {
- ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
+ ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
return false;
}
--
2.13.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()
2017-07-19 18:24 ` Gabriel Craciunescu
@ 2017-07-19 18:41 ` Ryan Hsu
2017-07-19 19:19 ` [PATCH v3] ath10k: ath10k_htt_rx_amsdu_allowed() " Gabriel Craciunescu
0 siblings, 1 reply; 7+ messages in thread
From: Ryan Hsu @ 2017-07-19 18:41 UTC (permalink / raw)
To: Gabriel Craciunescu, ath10k
Cc: Ryan Hsu, joe, Kalle Valo, linux-wireless, linux-kernel, netdev
On 07/19/2017 11:24 AM, Gabriel Craciunescu wrote:
To make it consistent, maybe rename the patch title starting with ath10k:
> From: Gabriel Craciunescu <nix.or.die@gmail.com>
>
> Each time we get disconencted from AP we get flooded with messages like:
>
> ...
> ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
> <until ratelimit kicks in>
> ath10k_warn: 155 callbacks suppressed
> ...
>
> Use ath10k_dbg() here too.
You don't need an indentation on every line of the commit.
> Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
> ---
> drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wirel=
ess/ath/ath10k/htt_rx.c
> index 398dda978d6e..75d9b59b7e63 100644
> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath1=
0k *ar,
> */
> =20
> if (!rx_status->freq) {
> - ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
> + ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(=
s)!\n");
> return false;
> }
> =20
--=20
Ryan Hsu
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v3] ath10k: ath10k_htt_rx_amsdu_allowed() use ath10k_dbg()
2017-07-19 18:41 ` Ryan Hsu
@ 2017-07-19 19:19 ` Gabriel Craciunescu
2017-08-08 11:06 ` [v3] " Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: Gabriel Craciunescu @ 2017-07-19 19:19 UTC (permalink / raw)
To: ath10k
Cc: ryanhsu, joe, kvalo, linux-wireless, linux-kernel, netdev,
Gabriel Craciunescu
Each time we get disconencted from AP we get flooded with messages like:
...
ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
<until ratelimit kicks in>
ath10k_warn: 155 callbacks suppressed
...
Use ath10k_dbg() here too
Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 398dda978d6e..75d9b59b7e63 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
*/
if (!rx_status->freq) {
- ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
+ ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
return false;
}
--
2.13.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-08-08 11:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-19 15:37 [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg() Gabriel C
2017-07-19 16:26 ` Joe Perches
2017-07-19 18:12 ` Gabriel C
2017-07-19 18:24 ` Gabriel Craciunescu
2017-07-19 18:41 ` Ryan Hsu
2017-07-19 19:19 ` [PATCH v3] ath10k: ath10k_htt_rx_amsdu_allowed() " Gabriel Craciunescu
2017-08-08 11:06 ` [v3] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).